Crate not found in integration tests if `crate-type = ["cdylib"]` #6659

ckaran · 2019-02-13T18:54:44Z

Problem
I am developing code that needs to work with python, which requires me to have a crate type of cdylib. It turns out that when you follow the recommendation to use a tests directory, the code within the directory cannot find the crate, failing with an error like the following:

   Compiling cargo_issue_6659 v0.1.0 (/home/cfkaran2/Desktop/cargo_issue_6659)
     Running `rustc --edition=2018 --crate-name tester tests/tester.rs --color always --emit=dep-info,link -C debuginfo=2 --test -C metadata=0525a91fc572753f -C extra-filename=-0525a91fc572753f --out-dir /home/cfkaran2/Desktop/cargo_issue_6659/target/debug/deps -C incremental=/home/cfkaran2/Desktop/cargo_issue_6659/target/debug/incremental -L dependency=/home/cfkaran2/Desktop/cargo_issue_6659/target/debug/deps`
     Running `rustc --edition=2018 --crate-name cargo_issue_6659 src/lib.rs --color always --emit=dep-info,link -C debuginfo=2 --test -C metadata=b9fa70b838dfddae -C extra-filename=-b9fa70b838dfddae --out-dir /home/cfkaran2/Desktop/cargo_issue_6659/target/debug/deps -C incremental=/home/cfkaran2/Desktop/cargo_issue_6659/target/debug/incremental -L dependency=/home/cfkaran2/Desktop/cargo_issue_6659/target/debug/deps`
error[E0463]: can't find crate for `rustc_issue_report_cdylib`
 --> tests/tester.rs:1:1
  |
1 | extern crate rustc_issue_report_cdylib;
  | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ can't find crate

error: aborting due to previous error

For more information about this error, try `rustc --explain E0463`.
error: Could not compile `cargo_issue_6659`.

Caused by:
  process didn't exit successfully: `rustc --edition=2018 --crate-name tester tests/tester.rs --color always --emit=dep-info,link -C debuginfo=2 --test -C metadata=0525a91fc572753f -C extra-filename=-0525a91fc572753f --out-dir /home/cfkaran2/Desktop/cargo_issue_6659/target/debug/deps -C incremental=/home/cfkaran2/Desktop/cargo_issue_6659/target/debug/incremental -L dependency=/home/cfkaran2/Desktop/cargo_issue_6659/target/debug/deps` (exit code: 1)
warning: build failed, waiting for other jobs to finish...
error: build failed

Steps

Checkout the repository at https://github.com/ckaran/cargo_issue_6659.
Follow the instructions in the README.md

Possible Solution(s)

None known.

Notes

$ cargo -V -vvv
cargo 1.32.0 (8610973aa 2019-01-02)
release: 1.32.0
commit-hash: 8610973aaf48615ba7dc9a38a9a2795ba6f36a31
commit-date: 2019-01-02

$ rustc -Vv
rustc 1.32.0 (9fda7c223 2019-01-16)
binary: rustc
commit-hash: 9fda7c2237db910e41d6a712e9a2139b352e558b
commit-date: 2019-01-16
host: x86_64-unknown-linux-gnu
release: 1.32.0
LLVM version: 8.0

$ uname -a
Linux EMANE 4.15.0-45-generic #48-Ubuntu SMP Tue Jan 29 16:28:13 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

$ lsb_release --all
No LSB modules are available.
Distributor ID: Ubuntu
Description:    Ubuntu 18.04.2 LTS
Release:    18.04
Codename:   bionic

The text was updated successfully, but these errors were encountered:

This repository contains all information needed to duplicate the bug report for cargo (issue at rust-lang/cargo#6659).

ehuss · 2019-02-13T19:30:47Z

You can add rlib (or lib) to the crate-type list, and it should work. Tests can't link to the cdylib.

BTW, there's a typo in your example, tests/tester.rs should have extern crate cargo_issue_6659;.

ckaran · 2019-02-13T20:48:26Z

Ah, sorry, since there is a chicken & egg problem between creating a repo that has the same name as the issue it's for, I sometimes forget to change the names. Now fixed.

As for setting to an rlib or lib, the problem is that I'm using pyo3, which says that you must set the library type to cdylib, and not having my integration tests work was surprising to me. If it is known that tests can't link to cdylib type libraries, it may be worth updating cargo's (or maybe rustc's) documentation to reflect this fact.

ehuss · 2019-02-13T22:16:05Z

Yea, the documentation for crate-types could definitely be improved in general.

Feel free to leave more comments here if you run into any other issues. Otherwise I'll just leave this open as a documentation issue.

Most of the tests for example Oak Applications just use the external gRPC service definition for testing, and so can be external integration tests rather than unit tests. This does require an "rlib" target for the modules though, because of rust-lang/cargo#6659 The trusted_information_retrieval example's tests included both unit tests and integration tests, so is split. Along the way, make the floating comparisons in the unit tests a bit more robust. Fixes #1054.

vjpr · 2021-10-01T22:33:54Z

There are some potential issues with just adding `lib' to get it to work. See: #4881.

This is related to an issue described here: rust-lang/cargo#6659 Without this change the `tests` directory can't access the scheduler crate.

Shatur · 2022-10-18T11:25:16Z

You can add rlib (or lib) to the crate-type list, and it should work. Tests can't link to the cdylib.

I'd like to add that this doesn't work with no_std because cdylib target requires a panic_handler, but lib doesn't, and this results in symbol duplication when building tests.

gzurl · 2023-05-05T18:57:37Z

You can add rlib (or lib) to the crate-type list, and it should work. Tests can't link to the cdylib.

BTW, there's a typo in your example, tests/tester.rs should have extern crate cargo_issue_6659;.

@ehuss, is adding a second crate-type (such as rlib) still the preferred way to solve this?
It works, but it makes cargo build last longer since it has to generate two libraries...

ehuss · 2023-05-05T19:11:48Z

I don't think there is any other way to do it right now.

- Move some of the existing tests to tests/db.rs - Split out an internal "kirunadb_test_helpers" crate for code shared between unit and integration tests. - Make transaction_manager module public, for integration tests, fix the new Clippy warnings. - Add "rlib" crate type for kirunadb so that the integration tests could actually import it. This is rust-lang/cargo#6659 and it can be removed once that issue is fixed.

As mentioned upstream[^1] the integration tests aren't able to use cdylib crate types so "lib" was added to the list of crate types. To not having to repeat the plugin interface types for Rust in the integration test they were made public in the library. The integration test needs a running MQTT server to which it will connect. That way the full functionality (except for mstarConfigure with its UI) can be tested. [^1]: rust-lang/cargo#6659 (comment)

Adds an entry point on the rust side. Had to change cdylib to rdlib (rust-lang/cargo#6659)

Adds an entry point on the rust side. Had to change cdylib to rdlib (see rust-lang/cargo#6659)

ckaran added the C-bug Category: bug label Feb 13, 2019

ckaran added a commit to ckaran/cargo_issue_6659 that referenced this issue Feb 13, 2019

Completed bug report.

8437813

This repository contains all information needed to duplicate the bug report for cargo (issue at rust-lang/cargo#6659).

ehuss added A-documenting-cargo-itself Area: Cargo's documentation and removed C-bug Category: bug labels Feb 13, 2019

notdanilo mentioned this issue Nov 18, 2019

HTML Rendering System enso-org/ide#48

Merged

3 tasks

ehuss added the A-crate-types Area: crate-type declaration (lib, staticlib, dylib, cdylib, etc.) label Apr 6, 2020

daviddrysdale mentioned this issue Jun 15, 2020

examples: move tests to be integration tests project-oak/oak#1154

Merged

6 tasks

magurotuna mentioned this issue Nov 5, 2020

Add rlib to crate-type in Cargo.toml rustwasm/rust-webpack-template#177

Open

OrangeTux mentioned this issue Dec 16, 2020

Integration tests can't find crate PyO3/pyo3#1321

Closed

nivekithan mentioned this issue Aug 24, 2021

error[E0463]: can't find crate for llvm_sys #9838

Closed

egithinji mentioned this issue Aug 26, 2022

Adjust cargo.toml to allow integration tests to work tijlleenders/ZinZen-scheduler#46

Merged

epage added the S-triage Status: This issue is waiting on initial triage. label Oct 31, 2023

ozaner added a commit to ozaner/py03_template that referenced this issue Mar 5, 2024

Add binary to Cargo.toml

e44f7c9

Adds an entry point on the rust side. Had to change cdylib to rdlib (rust-lang/cargo#6659)

ozaner added a commit to ozaner/py03_template that referenced this issue Mar 22, 2024

Add binary to Cargo.toml

28054c8

Adds an entry point on the rust side. Had to change cdylib to rdlib (see rust-lang/cargo#6659)

DavePearce mentioned this issue Apr 11, 2024

Restructure into Standard Rust Project Layout Consensys/corset#118

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Crate not found in integration tests if `crate-type = ["cdylib"]` #6659

Crate not found in integration tests if `crate-type = ["cdylib"]` #6659

ckaran commented Feb 13, 2019 •

edited

Loading

ehuss commented Feb 13, 2019

ckaran commented Feb 13, 2019

ehuss commented Feb 13, 2019

vjpr commented Oct 1, 2021

Shatur commented Oct 18, 2022 •

edited

Loading

gzurl commented May 5, 2023

ehuss commented May 5, 2023

Crate not found in integration tests if crate-type = ["cdylib"] #6659

Crate not found in integration tests if crate-type = ["cdylib"] #6659

Comments

ckaran commented Feb 13, 2019 • edited Loading

ehuss commented Feb 13, 2019

ckaran commented Feb 13, 2019

ehuss commented Feb 13, 2019

vjpr commented Oct 1, 2021

Shatur commented Oct 18, 2022 • edited Loading

gzurl commented May 5, 2023

ehuss commented May 5, 2023

Crate not found in integration tests if `crate-type = ["cdylib"]` #6659

Crate not found in integration tests if `crate-type = ["cdylib"]` #6659

ckaran commented Feb 13, 2019 •

edited

Loading

Shatur commented Oct 18, 2022 •

edited

Loading