Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/migrations typescript support #132

Merged

Conversation

Standaa
Copy link
Contributor

@Standaa Standaa commented Mar 29, 2021

Below code adds support for Ts migration files.
Things to know:
• The script will transpile the deploy.ts file using tsc to the migrations dir. The resulting deploy.js will be deleted upon successful script completion.

• There are some conflicts when using import * as anchor from "..." with a 3rd party lib. Hence the script sticking with commonjs require. Intellisense raises a missing @types/node.

• I added a different template in ts_deploy_script with an example ts async function although it was not absolutely necessary. I thought this template was bound to evolve in the future and that it provided clearer intent to readers.

@armaniferrante
Copy link
Member

armaniferrante commented Mar 30, 2021

The build is failing due to solana-labs/solana#16207. It also fails on master, so it's not caused by these changes.

@armaniferrante armaniferrante merged commit 7f2ef23 into coral-xyz:master Mar 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants