[RS-2320] Add QoS support in OpenStack code #9811
Conversation
marvin-tigera
added
release-note-required
nelljerram
force-pushed
the
qos-openstack
branch
from
a71c1fa to
2d6dd0a
Compare
| # Max connection options, in advance of max connection support being added | ||
| # properly to the Neutron API. | ||
| cfg.IntOpt('max_ingress_connections_per_port', default=0, | ||
| help="If non-zero, a maximum number of ingress connections to impose on each port."), | ||
| cfg.IntOpt('max_egress_connections_per_port', default=0, | ||
| help="If non-zero, a maximum number of egress connections to impose on each port."), |
There was a problem hiding this comment.
apologies for my lack of knowledge in this, but is there a need for a calico configuration (say, in FelixConfig) analogous to this? how exactly is this set by a user?
There was a problem hiding this comment.
So this would be set in an /etc/neutron/neutron.conf file on the controller nodes, as:
...
[calico]
max_ingress_connections_per_port = 100
max_egress_connections_per_port = 100
...
I don't think it makes sense as a FelixConfig setting, because it's really just a stopgap for the Neutron DB currently missing these fields, and so the Neutron driver is the right place for temporary configuration to fill that gap.
If we think about a possible role for FelixConfig independently of OpenStack, then the question would be: given that we now support optional pod annotations for QoS, do we also want FelixConfig fields to set defaults for pods that don't have those annotations? It's certainly conceivable, but I haven't heard anyone saying that is actually required. If it was required, I assume it would be required equally for all of the possible QoS fields.
WDYT, does that all make sense?
There was a problem hiding this comment.
I get it now, thanks @nelljerram! I agree it only makes sense on the neutron config, as far as I can tell there is no requirement to set defaults when unset. Thanks once again!
Sorry, these are more required plumbing changes that I missed in projectcalico#9811 and projectcalico#9856. Also a key fix to query bandwidth limit and packet rate rules directly, instead of via the policy, as the policy object does not really have a 'rules' attribute. After these, I've verified that I can execute the QoS workflow in https://docs.openstack.org/neutron/latest/admin/config-qos.html#user-workflow.
Add QoS support in OpenStack code
This is the OpenStack-specific coding that matches up with #9744
Todos
Release Note