Revert declaration that _our_ plugin provides QoS support #9856
+0
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In fact QoS support is provided by the 'qos' service plugin, which is configured with
service_plugins = qos
in `/etc/neutron/neutron.conf`. It's wrong to declare it here as well, and that causes a traceback
ending with:
2025-02-17 12:34:56.469 40638 ERROR neutron File "/usr/lib/python3/dist-packages/neutron/api/extensions.py", line 492, in __init__
2025-02-17 12:34:56.469 40638 ERROR neutron self.check_if_plugin_extensions_loaded()
2025-02-17 12:34:56.469 40638 ERROR neutron File "/usr/lib/python3/dist-packages/neutron/api/extensions.py", line 572, in check_if_plugin_extensions_loaded
2025-02-17 12:34:56.469 40638 ERROR neutron raise exceptions.ExtensionsNotFound(
2025-02-17 12:34:56.469 40638 ERROR neutron neutron_lib.exceptions.ExtensionsNotFound: Extensions not found: ['qos'].
Looking at `check_if_plugin_extensions_loaded`, we see
def check_if_plugin_extensions_loaded(self):
"""Check if an extension supported by a plugin has been loaded."""
plugin_extensions = self.get_supported_extension_aliases()
missing_aliases = plugin_extensions - set(self.extensions)
missing_aliases -= _PLUGIN_AGNOSTIC_EXTENSIONS
if missing_aliases:
raise exceptions.ExtensionsNotFound(
extensions=list(missing_aliases))
so it's clear that this is caused by the wrong `_supported_extension_aliases` declaration in our
plugin code.
marvin-tigera
added
release-note-required
nelljerram
added
docs-not-required
|
(This declaration was mistakenly added in #9811 ) |
|
(This is why calico-test CI is currently 100% fail, since the merging of #9811 ) |
fasaxc
approved these changes
Feb 17, 2025
nelljerram
added a commit
to nelljerram/calico
that referenced
this pull request
Feb 20, 2025
Sorry, these are more required plumbing changes that I missed in projectcalico#9811 and projectcalico#9856. Also a key fix to query bandwidth limit and packet rate rules directly, instead of via the policy, as the policy object does not really have a 'rules' attribute. After these, I've verified that I can execute the QoS workflow in https://docs.openstack.org/neutron/latest/admin/config-qos.html#user-workflow.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In fact QoS support is provided by the 'qos' service plugin, which is configured with
in
/etc/neutron/neutron.conf. It's wrong to declare it here as well, and that causes a traceback ending with:Looking at
check_if_plugin_extensions_loaded, we seeso it's clear that this is caused by the wrong
_supported_extension_aliasesdeclaration in our plugin code.