Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

move off off docker.io #3998

Closed
jayunit100 opened this issue Aug 27, 2021 · 4 comments · Fixed by #4314
Closed

move off off docker.io #3998

jayunit100 opened this issue Aug 27, 2021 · 4 comments · Fixed by #4314
Assignees
@skriss
Labels
area/deployment Issues or PRs related to deployment tooling or infrastructure.
Milestone
1.21.0

Comments

@jayunit100
Copy link

What steps did you take and what happened:

I think the default docker images for contour are still on dockerhub...

docker.io/projectcontour/contour:v1.18.1

What did you expect to happen:
given rate-limiting, maybe we should default the docker images from contour to gcr.io or some other public bucket?
@jayunit100 jayunit100 added kind/bug Categorizes issue or PR as related to a bug. lifecycle/needs-triage Indicates that an issue needs to be triaged by a project contributor. labels Aug 27, 2021
@youngnick
Copy link
Member

#3366 also covers this work, although reviewing it, I probably should close that out and open an implementation issue.

@skriss skriss mentioned this issue Sep 1, 2021
Closed
@skriss skriss self-assigned this Sep 1, 2021
@skriss skriss added area/deployment Issues or PRs related to deployment tooling or infrastructure. and removed kind/bug Categorizes issue or PR as related to a bug. lifecycle/needs-triage Indicates that an issue needs to be triaged by a project contributor. labels Sep 1, 2021
skriss added a commit to skriss/contour that referenced this issue Sep 1, 2021
@skriss
use GHCR image by default
08db655 
Updates examples, CI and docs to use
the GHCR image by default. The Docker
Hub image will continue to be pushed
for the time being to help migration.

Updates projectcontour#3998.

Signed-off-by: Steve Kriss <krisss@vmware.com>
@skriss
Copy link
Member

skriss commented Sep 1, 2021 •
edited
Loading

Todo list:

  • Start pushing to GHCR in parallel with Docker Hub, for both main and tag builds. Continue to reference the Docker Hub image in examples & CI for now. This will let us confirm everything is working with GHCR.
  • Publicize that we'll be migrating to GHCR and we'll stop pushing to Docker Hub after release v1.2x (maybe v1.21?)
  • Continue pushing to both registries, but switch example YAML & all other refs over to GHCR. Ideally we can do this for the 1.19 release if everything's in order, to start the migration (use GHCR image by default #4010 and use GHCR image by default contour-operator#439).
  • After the release we decide on from Step 2 (e.g. v1.21), turn off the Docker Hub push. Existing images will be left there indefinitely for posterity, but no new images will be pushed.
  • Manually push the last ~year's worth of release-tagged images from Docker Hub to GHCR, just so they're all there.

skriss added a commit that referenced this issue Sep 7, 2021
@skriss
use GHCR image by default (#4010)
98e35f8 
Updates examples, CI and docs to use
the GHCR image by default. The Docker
Hub image will continue to be pushed
for the time being to help migration.

Updates #3998.

Signed-off-by: Steve Kriss <krisss@vmware.com>
@skriss
Copy link
Member

skriss commented Sep 13, 2021

Last step can be done after v1.21 is released.

@skriss
Copy link
Member

skriss commented Dec 1, 2021

Since we're moving to quarterly releases, I'm going to propose that the upcoming 1.20 release be the last one where we push images to docker.io.

@skriss skriss mentioned this issue Dec 1, 2021
Closed
skriss added a commit to skriss/contour that referenced this issue Jan 31, 2022
@skriss
stop pushing images to Docker Hub
6e623e9 
Removes the Docker Hub image push since
images are now published on GHCR.

Closes projectcontour#3998.

Signed-off-by: Steve Kriss <krisss@vmware.com>
@skriss skriss mentioned this issue Jan 31, 2022
Merged
@skriss skriss added this to the 1.21.0 milestone Jan 31, 2022
skriss added a commit that referenced this issue Feb 3, 2022
@skriss
stop pushing images to Docker Hub (#4314)
15b2c6e 
Removes the Docker Hub image push since
images are now published on GHCR.

Closes #3998.

Signed-off-by: Steve Kriss <krisss@vmware.com>
erwbgy pushed a commit to erwbgy/contour that referenced this issue Feb 5, 2022
@skriss @erwbgy
stop pushing images to Docker Hub (projectcontour#4314)
a02639d 
Removes the Docker Hub image push since
images are now published on GHCR.

Closes projectcontour#3998.

Signed-off-by: Steve Kriss <krisss@vmware.com>

rebase
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@skriss skriss

Labels
area/deployment Issues or PRs related to deployment tooling or infrastructure.
Projects
None yet
Milestone
1.21.0
Development

Successfully merging a pull request may close this issue.

stop pushing images to Docker Hub skriss/contour
3 participants
@jayunit100 @skriss @youngnick