stop pushing images to Docker Hub #4314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removes the Docker Hub image push since images are now published on GHCR. Closes projectcontour#3998. Signed-off-by: Steve Kriss <krisss@vmware.com>
skriss
requested review from
stevesloka and
sunjayBhatia
and removed request for
a team
skriss
added
the
release-note/major
Codecov Report
@@ Coverage Diff @@
## main #4314 +/- ##
=======================================
Coverage 77.81% 77.81%
=======================================
Files 112 112
Lines 10032 10032
=======================================
Hits 7806 7806
Misses 2044 2044
Partials 182 182 |
sunjayBhatia
approved these changes
Jan 31, 2022
youngnick
approved these changes
Feb 1, 2022
erwbgy
pushed a commit
to erwbgy/contour
that referenced
this pull request
Feb 5, 2022
Removes the Docker Hub image push since images are now published on GHCR. Closes projectcontour#3998. Signed-off-by: Steve Kriss <krisss@vmware.com> rebase
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the Docker Hub image push since
images are now published on GHCR.
Closes #3998.
Signed-off-by: Steve Kriss krisss@vmware.com
Last chance for anyone to weigh in if they think this is a bad idea and we should keep pushing images to Docker Hub in the background!