Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove fastdialer from runner object #1174

Merged
merged 1 commit into from
May 16, 2023
Merged

remove fastdialer from runner object #1174

merged 1 commit into from
May 16, 2023

Conversation

ShubhamRasal
Copy link
Contributor

No description provided.

@ShubhamRasal ShubhamRasal self-assigned this May 16, 2023
@ShubhamRasal ShubhamRasal linked an issue May 16, 2023 that may be closed by this pull request
Used httpx as the go library. runner.fastdialer not close and rateLimiter not stop #1086
Closed
@ehsandeep ehsandeep requested a review from Mzack9999 May 16, 2023 13:12
Mzack9999
Mzack9999 approved these changes May 16, 2023
View reviewed changes
Copy link
Member

@Mzack9999 Mzack9999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Mzack9999 Mzack9999 merged commit 9566276 into dev May 16, 2023
@Mzack9999 Mzack9999 deleted the fastdialer-memory-leak branch May 16, 2023 17:26
@Mzack9999 Mzack9999 mentioned this pull request May 26, 2023
Closed
@ehsandeep ehsandeep added the Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors. label Jun 13, 2023
@Porkepix Porkepix mentioned this pull request Jun 13, 2023
Merged
@ppb007 ppb007 mentioned this pull request Jun 13, 2023
Closed
@ehsandeep ehsandeep mentioned this pull request Jun 17, 2023
Merged
@ppb007 ppb007 mentioned this pull request Jun 21, 2023
Closed
@ppb007 ppb007 mentioned this pull request Jul 23, 2023
Closed
@ppb007 ppb007 mentioned this pull request Sep 15, 2023
Closed
@ppb007 ppb007 mentioned this pull request Oct 31, 2023
Closed
@ppb007 ppb007 mentioned this pull request Nov 13, 2023
Closed
@ppb007 ppb007 mentioned this pull request Jan 16, 2024
Closed
@ppb007 ppb007 mentioned this pull request Jan 24, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mzack9999 Mzack9999 Mzack9999 approved these changes

Assignees

@ShubhamRasal ShubhamRasal

Labels
Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Used httpx as the go library. runner.fastdialer not close and rateLimiter not stop
3 participants
@ShubhamRasal @Mzack9999 @ehsandeep