Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix rateLimiter not stop #1236

Merged
merged 1 commit into from
Jun 19, 2023
Merged

fix rateLimiter not stop #1236

merged 1 commit into from
Jun 19, 2023

Conversation

anhnmt
Copy link
Contributor

@anhnmt anhnmt commented Jun 16, 2023

This commit fixes the issue #1086

@ehsandeep
Copy link
Member

@anhnmt it was fixed in dev version with #1174, do you still experience the same issue with dev version?

@ehsandeep ehsandeep added the Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors. label Jun 17, 2023
@anhnmt
Copy link
Contributor Author

anhnmt commented Jun 17, 2023

@ehsandeep yes i used developer version and had problem related to ratelimit still increasing goroutine count

goroutine profile: total 3135
2749 @ 0x439cd6 0x449f7e 0x1371dac 0x46c861
#	0x1371dab	github.com/projectdiscovery/ratelimit.(*Limiter).run+0x16b	/go/pkg/mod/github.com/projectdiscovery/ratelimit@v0.0.8/ratelimit.go:31

after using close ratelimit the problem is solved

@ehsandeep ehsandeep requested a review from ShubhamRasal June 17, 2023 18:17
ShubhamRasal
ShubhamRasal approved these changes Jun 19, 2023
View reviewed changes
Copy link
Contributor

@ShubhamRasal ShubhamRasal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@anhnmt Thanks for this, We missed the closing the rate limiter.

@ShubhamRasal ShubhamRasal merged commit c119939 into projectdiscovery:dev Jun 19, 2023
@ShubhamRasal ShubhamRasal linked an issue Jun 19, 2023 that may be closed by this pull request
Used httpx as the go library. runner.fastdialer not close and rateLimiter not stop #1086
Closed
@Porkepix Porkepix mentioned this pull request Jun 21, 2023
Merged
@ppb007 ppb007 mentioned this pull request Jun 21, 2023
Closed
@ppb007 ppb007 mentioned this pull request Jul 23, 2023
Closed
@ppb007 ppb007 mentioned this pull request Sep 15, 2023
Closed
@ppb007 ppb007 mentioned this pull request Oct 31, 2023
Closed
@ppb007 ppb007 mentioned this pull request Nov 13, 2023
Closed
@ppb007 ppb007 mentioned this pull request Jan 16, 2024
Closed
@ppb007 ppb007 mentioned this pull request Jan 24, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShubhamRasal ShubhamRasal ShubhamRasal approved these changes

Assignees
No one assigned
Labels
Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Used httpx as the go library. runner.fastdialer not close and rateLimiter not stop
3 participants
@anhnmt @ehsandeep @ShubhamRasal