Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix nocolor output #4954

Merged
merged 3 commits into from
Apr 1, 2024
Merged

fix nocolor output #4954

merged 3 commits into from
Apr 1, 2024

Conversation

dogancanbakir
Copy link
Member

Proposed changes

Closes #4952

image

Checklist

  • Pull request is created against the dev branch
  • All checks passed (lint, unit/integration/regression tests etc.) with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@dogancanbakir dogancanbakir self-assigned this Mar 28, 2024
ehsandeep
ehsandeep requested changes Apr 1, 2024
View reviewed changes
Copy link
Member

@ehsandeep ehsandeep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

merge conflict

@ehsandeep ehsandeep merged commit dccfc10 into dev Apr 1, 2024
12 checks passed
@ehsandeep ehsandeep deleted the fix_nocolor_output branch April 1, 2024 20:11
@BrewTestBot BrewTestBot mentioned this pull request Apr 3, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ehsandeep ehsandeep ehsandeep approved these changes

Assignees

@dogancanbakir dogancanbakir

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Output is still coloured/not respecting the -nc flag
2 participants
@dogancanbakir @ehsandeep