Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restrict variant keys to Identifiers and NumberLiterals #157

Merged
merged 1 commit into from
Aug 30, 2018
Merged

Restrict variant keys to Identifiers and NumberLiterals #157

merged 1 commit into from
Aug 30, 2018

Conversation

stasm
Copy link
Contributor

@stasm stasm commented Jul 26, 2018

Fix #127.

@stasm stasm requested a review from Pike July 26, 2018 08:05
@stasm
Copy link
Contributor Author

stasm commented Jul 26, 2018

Hey @Pike, this implements my proposal from #127. I'd like to play it safe and restrict the grammar where it makes sense.

@stasm stasm mentioned this pull request Jul 26, 2018
Closed
@stasm stasm force-pushed the restrict-variant-key branch 2 times, most recently from 495a743 to 0f8809f Compare August 28, 2018 10:07
@stasm stasm mentioned this pull request Aug 28, 2018
Closed
@Pike Pike removed their request for review August 28, 2018 15:00
@Pike
Copy link
Contributor

Pike commented Aug 28, 2018

Sorry, but I don't see me doing an actual review here.

@stasm
Copy link
Contributor Author

stasm commented Aug 30, 2018

OK. thanks. I'm going to merge this in order to close #127 which is the last remaining issue for the 0.7 milestone.

@stasm stasm merged commit 715fc4d into projectfluent:master Aug 30, 2018
@stasm stasm deleted the restrict-variant-key branch August 30, 2018 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stasm @Pike