New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce the Name node for attribute and variant names #172

Closed

stasm wants to merge 3 commits into projectfluent:master from stasm:identifier-name

Contributor

stasm commented Aug 28, 2018

This is another fix to #127 and an alternative to #157.

stasm added 3 commits

August 28, 2018 11:26


Restrict variant keys to Identifiers and NumberLiterals

0f8809f


Add a Name AST node

98082d0


Rename Attribute.id to Attribute.name

495a743

stasm mentioned this pull request

Restrict variant keys to Numbers and Identifier #127

Closed

Contributor Author

stasm commented Aug 30, 2018

We went with #157. Closing this for now. Let's have a proper discussion about Name in #173.

stasm closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment