Remove unnecessary list operations #1456
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 91.17% // Head: 91.16% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1456 +/- ##
==========================================
- Coverage 91.17% 91.16% -0.02%
==========================================
Files 15 15
Lines 1292 1290 -2
Branches 218 218
==========================================
- Hits 1178 1176 -2
Misses 81 81
Partials 33 33
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
rht
reviewed
Oct 19, 2022
rht
reviewed
Oct 19, 2022
Tortar
force-pushed
the
patch-9
branch
2 times, most recently
from
ecf7bb4 to
3235917
Compare
|
Made all necessary changes I think @rht |
rht
reviewed
Oct 19, 2022
|
LGTM |
Tortar
added a commit
to Tortar/mesa
that referenced
this pull request
Nov 7, 2022
These PRs are reversed because they introduce the bug discussed in projectmesa#1515
Tortar
added a commit
to Tortar/mesa
that referenced
this pull request
Nov 7, 2022
These PRs are reverted because they introduce the bug discussed in projectmesa#1515
rht
added a commit
that referenced
this pull request
Nov 8, 2022
* Revert changes of #1478 and parts of #1456 These PRs are reverted because they introduce the bug discussed in #1515 which prevents agents from being added/removed while looping through the agent keys. * Update time.py * Add full stop to comment. * Add more full stop to comment Co-authored-by: rht <rhtbot@protonmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The transformation in list is not necessary to iterate over the keys