Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1.2.0 Taylor Release #1599

Closed
4 tasks done
jackiekazil opened this issue Feb 12, 2023 · 15 comments
Closed
4 tasks done

v1.2.0 Taylor Release #1599

jackiekazil opened this issue Feb 12, 2023 · 15 comments
Milestone

Comments

@jackiekazil
Copy link
Member

jackiekazil commented Feb 12, 2023

@jackiekazil jackiekazil added this to the v1.2.0 Taylor milestone Feb 12, 2023
@rht
Copy link
Contributor

rht commented Feb 15, 2023

There are lots of recent PRs that are not tagged (https://github.com/projectmesa/mesa/pulls?page=1&q=is%3Apr+no%3Amilestone+is%3Aclosed). Though I forgot the reason why all of them have to be tagged to a milestone for a release. I thought issues in milestone are reserved for only the ones that are necessary and are blocking the release itself.

@jackiekazil
Copy link
Member Author

@rht I had always done it as a tracking mechanism to try to correlate with history -- it is mostly focused on PRs so they are easy to find.

@rht
Copy link
Contributor

rht commented Feb 16, 2023

We could collect them all by the timestamps (all recent merged PR's after the release PR) and put them in the HISTORY.rst. I don't see having to find the release tag of a PR to be a common use case. But I'm fine with having to tag the recent merged PRs as usual too.

@jackiekazil
Copy link
Member Author

@rht I think what you are suggesting is an automated process. We talked about that... let's revisit setting that up. I am going to do a manual tag for now before we switch to something new.

@jackiekazil
Copy link
Member Author

@rht, @tpike3 can either of you do a review of everything I tagged?
I wanted to pull in the errors too since they can impact things even though they were undone.
If there is something that shouldn't be tagged, please untag.
https://github.com/projectmesa/mesa/milestone/32?closed=1.

@jackiekazil
Copy link
Member Author

@rht - do you have any preference of history format?

@rht
Copy link
Contributor

rht commented Feb 27, 2023

There are old PRs/issues that have been accidentally tagged in https://github.com/projectmesa/mesa/milestone/32?closed=1. I have untagged them.

One feature with associating PRs with a milestone of a release is that you can track which release a PR is a part of, from its milestone. But this info is not used that often. Other projects use them for blocking issues:

I have no preference for the history format (at the moment).

@jackiekazil
Copy link
Member Author

jackiekazil commented Mar 7, 2023

Currently on a plane, but unable to push PRs. Here is a draft on history -- Feel free to this directly & comment generally on the changes. Also, what do we want to highlight in the Special notes?


1.2.0 (2023-03-09) Taylor
++++++++++++++++++++++++++

Special notes

New features:

Some highlights for the perf improvements:

Improvements

Fixes

@jackiekazil
Copy link
Member Author

@tpike3 ^^ Can you make sure any updates you pushed over the weekend are included?

@rht
Copy link
Contributor

rht commented Mar 7, 2023

examples: Initialize Sugarscape ({G1}, {M, T}) #1290

This one was merged in the examples repo.

@rht
Copy link
Contributor

rht commented Mar 8, 2023

New features:

Some highlights for the perf improvements:

Those are harder to find from the PR list because the PR titles don't explicitly have "perf:" prefix.
Overall, seems to be mainly perf, refactors, and bug fixes.

@tpike3
Copy link
Member

tpike3 commented Mar 8, 2023

@rht Thanks! @jackiekazil I have nothing else to add. That is an impressive list.

@jackiekazil
Copy link
Member Author

@rht I believe I made your changes. Can you review the PR?

RE: perf:, etc -- do we want to try to enforce this to for automate history writes in the future?

@tpike3 It was a lot more than I was expecting.

@rht
Copy link
Contributor

rht commented Mar 9, 2023

Yes, I will make sure that perf commits will have perf: prefix in the future.

@jackiekazil
Copy link
Member Author

https://pypi.org/project/Mesa/
^^ 1.2 is published. Closing this ticket. Please reopen if you notice any issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants