Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove _reporter_decorator #1591

Merged
merged 1 commit into from
Jan 24, 2023
Merged

Remove _reporter_decorator #1591

merged 1 commit into from
Jan 24, 2023

Conversation

Tortar
Copy link
Contributor

@Tortar Tortar commented Jan 24, 2023

This is not useful, we can just call reporter

@codecov
Copy link

codecov bot commented Jan 24, 2023

Codecov Report

Base: 82.06% // Head: 82.03% // Decreases project coverage by -0.03% ⚠️

Coverage data is based on head (42647bd) compared to base (e3cc4d4).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1591      +/-   ##
==========================================
- Coverage   82.06%   82.03%   -0.03%     
==========================================
  Files          18       18              
  Lines        1388     1386       -2     
  Branches      271      271              
==========================================
- Hits         1139     1137       -2     
  Misses        205      205              
  Partials       44       44              
Impacted Files Coverage Δ
mesa/datacollection.py 95.18% <100.00%> (-0.12%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@rht
Copy link
Contributor

rht commented Jan 24, 2023

This is the commit that introduced it: b0bacf5. In any case, removing the _reporter_decorator is strictly better.

@rht rht merged commit 5cd08ce into projectmesa:main Jan 24, 2023
@jackiekazil jackiekazil added this to the v1.2.0 Taylor milestone Feb 27, 2023
@jackiekazil jackiekazil mentioned this pull request Mar 7, 2023
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants