-
Notifications
You must be signed in to change notification settings - Fork 942
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: Replace flake8 with Ruff #1587
Conversation
Codecov ReportBase: 82.06% // Head: 82.06% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #1587 +/- ##
=======================================
Coverage 82.06% 82.06%
=======================================
Files 18 18
Lines 1388 1388
Branches 271 271
=======================================
Hits 1139 1139
Misses 205 205
Partials 44 44
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
It took 2 s to run flake8 on the codebase, and 1 s for Black. Now GH Actions says 0 s. Also, it is a single linter instead of separate. We should configure further to include |
I think it doesn't replace Black yet. It is meant to be used alongside Black. |
This LGTM, Ruff looks established (used by heavily supported libraries e.g. pandas) and reliable (large number of contributors so low bus factor). however as it is a significant dependency change, could I get a second @wang-boyu, @jackiekazil @EwoutH and then we can merge. |
Looks great! Probably there'll be more tools written in Rust in the future. I'll update Mesa-Geo with the same. |
Once this is merged, I will add more as configured in Zulip. |
LGTM. |
Ty @rht |
See https://notes.crmarsh.com/ruff-the-first-200-releases. Highlight:
@wang-boyu we should do this for Mesa-Geo. @EwoutH check this out.