Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix return types of some NetworkGrid methods #1505

Merged
merged 1 commit into from
Nov 4, 2022
Merged

Conversation

Tortar
Copy link
Contributor

@Tortar Tortar commented Nov 4, 2022

As discussed in #1498 the types of some functions were wrong

@codecov
Copy link

codecov bot commented Nov 4, 2022

Codecov Report

Base: 91.40% // Head: 91.32% // Decreases project coverage by -0.07% ⚠️

Coverage data is based on head (296fdbe) compared to base (8759f7b).
Patch coverage: 80.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1505      +/-   ##
==========================================
- Coverage   91.40%   91.32%   -0.08%     
==========================================
  Files          15       15              
  Lines        1303     1303              
  Branches      223      223              
==========================================
- Hits         1191     1190       -1     
- Misses         79       80       +1     
  Partials       33       33              
Impacted Files Coverage Δ
mesa/space.py 96.21% <80.00%> (-0.28%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@rht
Copy link
Contributor

rht commented Nov 4, 2022

LGTM

@rht rht merged commit c7ec7b4 into projectmesa:main Nov 4, 2022
@jackiekazil jackiekazil added this to the v1.2.0 Taylor milestone Feb 27, 2023
@jackiekazil jackiekazil mentioned this pull request Mar 7, 2023
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants