Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replacing local playbook.yml with ad-hoc previewer command #165

Merged
merged 9 commits into from
Sep 2, 2020
Merged

Replacing local playbook.yml with ad-hoc previewer command #165

merged 9 commits into from
Sep 2, 2020

Conversation

akosma
Copy link
Contributor

@akosma akosma commented Sep 2, 2020

This PR replaces the local playbook.yml file with an ad-hoc previewer command based on a Docker image.

Developers can make docs and preview their documentation in http://localhost:2020.

The vale related functionality is left unchanged.

Checklist

  • Keep pull requests small so they can be easily reviewed.
  • Update the documentation.
  • Update the ./CHANGELOG.md.
  • Link this PR to related issues.

@akosma akosma requested review from srueg and simu September 2, 2020 11:32
@akosma akosma requested a review from corvus-ch September 2, 2020 13:31
@akosma akosma mentioned this pull request Sep 2, 2020
Merged
@tobru tobru merged commit 64a6291 into master Sep 2, 2020
@tobru tobru deleted the playbook-removal branch September 2, 2020 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simu simu simu approved these changes

@srueg srueg Awaiting requested review from srueg

@corvus-ch corvus-ch Awaiting requested review from corvus-ch

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@akosma @simu @tobru