-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replacing local playbook.yml with ad-hoc previewer command #48
Conversation
…ad-hoc previewer command
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice one. Thanks
…teractive session now
Co-authored-by: Christian Häusler <794584+corvus-ch@users.noreply.github.com>
Great effort, here are a few comments:
Let's discuss and address this points here, before we do a mass update of all other Antora based repos. |
Maybe we could add all these |
Well the harmonization of all Makefiles with the same style will be quite a bit of work, as some are use UPPERCASE all over the place, others not… etc. This should probably be a separate task? For my part, I will update all the PRs with |
Oh, and add a message in the |
|
This PR replaces the local
playbook.yml
file with an ad-hoc previewer command based on a Docker image.Developers can still
make docs
and preview their documentation in http://localhost:2020.The
vale
related functionality is left unchanged.