Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replacing local playbook.yml with ad-hoc previewer command #48

Merged
merged 6 commits into from
Sep 2, 2020

Conversation

akosma
Copy link
Contributor

@akosma akosma commented Sep 2, 2020

This PR replaces the local playbook.yml file with an ad-hoc previewer command based on a Docker image.

Developers can still make docs and preview their documentation in http://localhost:2020.

The vale related functionality is left unchanged.

@akosma akosma requested review from corvus-ch and srueg September 2, 2020 06:55
Copy link
Contributor

@corvus-ch corvus-ch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one. Thanks

akosma and others added 2 commits September 2, 2020 10:15
Co-authored-by: Christian Häusler <794584+corvus-ch@users.noreply.github.com>
@akosma akosma requested a review from corvus-ch September 2, 2020 08:16
@tobru
Copy link
Contributor

tobru commented Sep 2, 2020

Great effort, here are a few comments:

  • The Makefile is a generic one for the whole project, not just for docs. So I would suggest to prefix all commands which are doing stuff for documentation with docs-. For example make docs-serve, make docs-vale, ... This way it's very clear that these commands are solely for working with documentation stuff.
  • make docs-open would be cool to have, calling either open or xdg-open, like discussed in the chat
    • Also do an echo "Documentation is available under http://localhost:2020/" when starting up the container, this way one can also just click on the link as most modern terminals discover URLs and make them clickable - as an alternative to make docs-open
  • Move the code for the image vshn/antora-preview to GitHub and make sure it has an appropriate license
  • All Project Syn tools should have a similar Makefile, all doing the same when calling make docs-XYZ. I haven't checked that in all the current open PRs though, but until now the commands weren't aligned. We might even make sure that all Antora based repositories are having the same make commands available, this helps with the muscle memory
  • https://github.com/appuio/openshift4-docs/blob/master/Makefile -> This one also has support for Podman, running the container in rootless mode. Would be cool to also have this on all other Makefiles, again to make all the Antora based projects as similar as possible.

Let's discuss and address this points here, before we do a mass update of all other Antora based repos.

@srueg
Copy link
Contributor

srueg commented Sep 2, 2020

Maybe we could add all these docs-* targets to a antora.mk file to include in the main Makefile?
I fear that otherwise the main Makefile gets really bloated. It would also help to keep them in sync (i.e. also with module-sync at some point).

@akosma
Copy link
Contributor Author

akosma commented Sep 2, 2020

Well the harmonization of all Makefiles with the same style will be quite a bit of work, as some are use UPPERCASE all over the place, others not… etc. This should probably be a separate task?

For my part, I will update all the PRs with docs-serve and docs-vale tasks, and will move the project to Github.

@akosma
Copy link
Contributor Author

akosma commented Sep 2, 2020

Oh, and add a message in the antora-preview Docker image to remind the user to open a browser.

@tobru tobru merged commit beaf59d into master Sep 2, 2020
@tobru tobru deleted the playbook-removal branch September 2, 2020 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants