Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Rust crate pyo3 to v0.20.3 #102

Merged
merged 1 commit into from
Mar 19, 2024
Merged

Update Rust crate pyo3 to v0.20.3 #102

merged 1 commit into from
Mar 19, 2024

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Feb 23, 2024

Mend Renovate

This PR contains the following updates:

Package Type Update Change
pyo3 dependencies patch =0.20.2 -> =0.20.3

Release Notes

pyo3/pyo3 (pyo3)

v0.20.3

Compare Source

Packaging
  • Add portable-atomic dependency. #​3619
  • Check maximum version of Python at build time and for versions not yet supported require opt-in to the abi3 stable ABI by the environment variable PYO3_USE_ABI3_FORWARD_COMPATIBILITY=1. #​3821
Fixed
  • Use portable-atomic to support platforms without 64-bit atomics. #​3619
  • Fix compilation failure with either feature enabled without experimental-inspect enabled. #​3834

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@renovate renovate bot added the dependency label Feb 23, 2024

This comment was marked as outdated.

@simu
Copy link
Member

simu commented Feb 23, 2024

Looks like the Python version limit breaks the default maturin wheel builds. Leaving this unmerged for now.

@simu simu mentioned this pull request Feb 23, 2024
4 tasks
@renovate renovate bot changed the title Update Rust crate pyo3 to 0.20.3 Update Rust crate pyo3 to v0.20.3 Feb 23, 2024
Copy link

Benchmark for 495308b

Click to view benchmark
Test Base PR %
Reclass::inventory() multi-threaded 1638.4±118.26µs 1644.0±148.61µs +0.34%
Reclass::inventory() single-threaded 3.6±0.12ms 3.6±0.08ms 0.00%

Copy link

Benchmark for c027885

Click to view benchmark
Test Base PR %
Reclass::inventory() multi-threaded 1637.1±109.52µs 1621.1±59.27µs -0.98%
Reclass::inventory() single-threaded 3.6±0.09ms 3.6±0.04ms 0.00%

Copy link

Benchmark for abe72cf

Click to view benchmark
Test Base PR %
Reclass::inventory() multi-threaded 1632.1±115.36µs 1641.0±119.85µs +0.55%
Reclass::inventory() single-threaded 3.6±0.14ms 3.6±0.04ms 0.00%

@simu
Copy link
Member

simu commented Feb 26, 2024

CI issue has been reported upstream, cf. PyO3/maturin#1960

Copy link

Benchmark for 5b55a36

Click to view benchmark
Test Base PR %
Reclass::inventory() multi-threaded 1608.1±55.89µs 1640.4±120.18µs +2.01%
Reclass::inventory() single-threaded 3.6±0.04ms 3.7±0.29ms +2.78%

Copy link

Benchmark for 2d59dfe

Click to view benchmark
Test Base PR %
Reclass::inventory() multi-threaded 1623.7±63.53µs 1662.6±123.90µs +2.40%
Reclass::inventory() single-threaded 3.6±0.06ms 3.6±0.07ms 0.00%

Copy link

Benchmark for 1079427

Click to view benchmark
Test Base PR %
Reclass::inventory() multi-threaded 1614.5±54.64µs 1662.2±138.53µs +2.95%
Reclass::inventory() single-threaded 3.6±0.02ms 3.6±0.04ms 0.00%

Copy link

github-actions bot commented Mar 1, 2024

Benchmark for 1e28c19

Click to view benchmark
Test Base PR %
Reclass::inventory() multi-threaded 1637.9±126.35µs 1649.2±120.97µs +0.69%
Reclass::inventory() single-threaded 3.6±0.09ms 3.6±0.12ms 0.00%

Copy link

github-actions bot commented Mar 4, 2024

Benchmark for 293b922

Click to view benchmark
Test Base PR %
Reclass::inventory() multi-threaded 1655.3±120.27µs 1624.4±53.96µs -1.87%
Reclass::inventory() single-threaded 3.7±0.04ms 3.7±0.11ms 0.00%

Copy link

github-actions bot commented Mar 5, 2024

Benchmark for bbf5a48

Click to view benchmark
Test Base PR %
Reclass::inventory() multi-threaded 1613.8±53.36µs 1616.9±56.19µs +0.19%
Reclass::inventory() single-threaded 3.6±0.05ms 3.6±0.03ms 0.00%

Copy link

github-actions bot commented Mar 5, 2024

Benchmark for 4a2db1b

Click to view benchmark
Test Base PR %
Reclass::inventory() multi-threaded 1652.6±116.03µs 1628.2±93.28µs -1.48%
Reclass::inventory() single-threaded 3.6±0.11ms 3.6±0.14ms 0.00%

Copy link

github-actions bot commented Mar 7, 2024

Benchmark for bd95489

Click to view benchmark
Test Base PR %
Reclass::inventory() multi-threaded 1658.1±125.38µs 1664.1±124.69µs +0.36%
Reclass::inventory() single-threaded 3.7±0.06ms 3.6±0.07ms -2.70%

Copy link

Benchmark for 3bfa7f4

Click to view benchmark
Test Base PR %
Reclass::inventory() multi-threaded 1647.2±127.84µs 1659.8±169.52µs +0.76%
Reclass::inventory() single-threaded 3.6±0.11ms 3.6±0.06ms 0.00%

@simu
Copy link
Member

simu commented Mar 19, 2024

Since PyO3 is one of the most important dependencies of this project, I'll keep the exact version specification, since we'll get update PRs from Renovate regardless of whether we specify the exact version or just a patch version.

@simu
Copy link
Member

simu commented Mar 19, 2024

The CI issues have been fixed in maurin v1.5.0 which doesn't detect unsupported pre-release Python versions anymore when executed with --find-interpreter (cf. PyO3/maturin#1964).

Copy link

Benchmark for 04af110

Click to view benchmark
Test Base PR %
Reclass::inventory() multi-threaded 1612.5±57.37µs 1631.7±118.18µs +1.19%
Reclass::inventory() single-threaded 3.6±0.02ms 3.6±0.03ms 0.00%

@simu simu merged commit f58807f into main Mar 19, 2024
18 checks passed
@simu simu deleted the renovate/pyo3-0.x branch March 19, 2024 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant