Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force Cargo to use PyO3 0.20.2 #103

Merged
merged 1 commit into from
Feb 23, 2024
Merged

Force Cargo to use PyO3 0.20.2 #103

merged 1 commit into from
Feb 23, 2024

Conversation

simu
Copy link
Member

@simu simu commented Feb 23, 2024

PyO3 0.20.3 breaks building wheels with the default maturin GitHub action.

See also #102

Checklist

  • The PR has a meaningful title. The title will be used to auto generate the changelog
  • PR contains a single logical change (to build a better changelog).
  • Categorize the PR by setting a good title and adding one of the labels:
    bug, enhancement, documentation, change, breaking, dependency, internal
    as they show up in the changelog
  • Link this PR to related PRs or issues.

@simu simu added the ignore label Feb 23, 2024
@simu simu changed the title Force Cargo to build with PyO3 0.20.2 Force Cargo to use PyO3 v0.20.2 Feb 23, 2024
@simu simu changed the title Force Cargo to use PyO3 v0.20.2 Force Cargo to use PyO3 0.20.2 Feb 23, 2024
PyO3 0.20.3 breaks building wheels with the default maturin GitHub
action.

This comment was marked as outdated.

Copy link

Benchmark for e1a5ec9

Click to view benchmark
Test Base PR %
Reclass::inventory() multi-threaded 1631.0±114.01µs 1607.8±63.35µs -1.42%
Reclass::inventory() single-threaded 3.6±0.02ms 3.6±0.04ms 0.00%

@simu simu merged commit 3276ef0 into main Feb 23, 2024
18 checks passed
@simu simu deleted the force-pyo3-0.20.2 branch February 23, 2024 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant