-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Don't log config deployments #73
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because the variable is used in a template, arguments_spec won't work?
Because to me, it would be better to have the no_log on the variable instead of the whole task.
You wouldn't need to check the __testing
vars and in case of issue on production the task will output the error instead of the "no_log" warning.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rather than using our own variables I would prefer to use variables that are already present, some of these:
no_log: "{{ molecule_no_log }}"
no_log: "{{ (lookup('env', 'MOLECULE_DEBUG')) }}"
no_log: "{{ (lookup('env', 'CI')) }}"
(comes from github ci)- etc.
Ansible doesn't support |
521cfe4
to
ea87c12
Compare
Verified with a local verbose molecule test:
|
Avoid logging on some config files may contain secrets. Fixes: #72 Signed-off-by: prombot <prometheus-team@googlegroups.com>
ea87c12
to
e39934b
Compare
Avoid logging on some config files may contain secrets.
Fixes: #72