Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enabling required reviews on pull requests #15

Closed
scottrigby opened this issue Aug 16, 2020 · 3 comments
Closed

Enabling required reviews on pull requests #15

scottrigby opened this issue Aug 16, 2020 · 3 comments

Comments

@scottrigby
Copy link
Member

Do after #12
@scottrigby
Copy link
Member Author

Added ✅

Here are the main branch protection rules, for future ref:

screencapture-github-scottrigby-prometheus-helm-charts-settings-branch-protection-rules-17224145-2020-08-19-12_07_47

Note we don't enable branch protection on the GitHub pages branch used for helm repo indexing, because helm/chart-releaser-action force-pushes to keep things fully automated: https://github.com/helm/chart-releaser-action/blob/97237943efb7a48269d47a642ec5fdff675aa55f/cr.sh#L235

@Xtigyro
Copy link
Member

Xtigyro commented Aug 19, 2020 •
edited
Loading

Could we include please administrators?

@scottrigby
Copy link
Member Author

@Xtigyro done ✅

@scottrigby scottrigby mentioned this issue Aug 19, 2020
Closed
hectorj2f added a commit to hectorj2f/helm-charts that referenced this issue Nov 10, 2021
@hectorj2f
cosigned: add scripts to expose metrics to prometheus (prometheus-com…
6d3305c 
…munity#15)

* chore: add service monitor

Signed-off-by: hectorj2f <hectorf@vmware.com>

* chore: bump chart version

Signed-off-by: hectorj2f <hectorf@vmware.com>
sathieu pushed a commit to sathieu/helm-charts-prometheus-community that referenced this issue Nov 26, 2021
@alexisdondon
Tweet engine (prometheus-community#15)
526d6e2
junotx pushed a commit to junotx/prometheus-helm-charts that referenced this issue May 24, 2023
@benjaminhuo
Merge pull request prometheus-community#15 from junotx/wt-stack
989cc3f 
[kube-prometheus-stack] update some namespace configs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@scottrigby @Xtigyro