Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Give chart maintainer collaborators correct GitHub repo access level #20

Closed
scottrigby opened this issue Aug 19, 2020 · 10 comments
Closed

Comments

@scottrigby
Copy link
Member

After #11

See related #12 and #15

Context

Until #11 this repo is under my individual user account, therefore there is only one "collaborator" access level. But after this transfer, we will have options. One suggestion #12 (comment) was that all chart maintainers be given repo "Maintain" access level.

Example options list:
Screen Shot 2020-08-19 at 11 44 35 AM

Open questions

  1. GitHub docs for Maintain access says it allows members to Push to protected branches. Does this mean bypassing the rules in CODEOWNERS? I don't have a current repo set up for testing this
@monotek
Copy link
Member

monotek commented Aug 20, 2020

Imho you can disable push access for admins too. I hope I can try later. I'm in the phone most of the time as I'm on vacation.

@scottrigby
Copy link
Member Author

Update, now that #11 is complete, there is a new team set up for this – all current chart maintainers will be invited soon. Until then, you are all still "collaborators" on this repo.

@scottrigby scottrigby changed the title Give chart maintainer collaborators GitHub correct repo access level Give chart maintainer collaborators correct GitHub repo access level Sep 4, 2020
@scottrigby
Copy link
Member Author

For now the prometheus-community helm-charts-maintainers github team access is Write for this git repo, until we check out the above on a test repo.

@scottrigby
Copy link
Member Author

All existing chart maintainers have been invite to the @prometheus-community/helm-charts-maintainers team 👍 I'll remove your old collaborator status. You will all need to accept the invite to maintain Write access to your charts.

@gkarthiks
Copy link
Member

@scottrigby aah, that makes sense. All of a sudden git started complaining about the write access 🤣 . I will accept that now.

@scottrigby
Copy link
Member Author

@gkarthiks ok great. Please lmk if you run into any trouble- feel free to ping me on slack 🙂

@scottrigby
Copy link
Member Author

This is done

@desaintmartin
Copy link
Member

I don't think I've been invited, as I don't see any mail nor invitation in the github notifications pages, could you double check?

@scottrigby
Copy link
Member Author

Thanks @desaintmartin you should have an invite now

@desaintmartin
Copy link
Member

Done, thanks!

sathieu pushed a commit to sathieu/helm-charts-prometheus-community that referenced this issue Nov 26, 2021
junotx pushed a commit to junotx/prometheus-helm-charts that referenced this issue Oct 12, 2023
[prometheus-node-exporter] sync upstream update
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants