Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transfer ownership and rename scottrigby/prometheus-helm-charts to prometheus-community/helm-charts #11

Closed
2 tasks done
scottrigby opened this issue Aug 16, 2020 · 8 comments

Comments

@scottrigby
Copy link
Member

scottrigby commented Aug 16, 2020

Background

Fixes: prometheus-community/community#28 (comment)

Status

📊 Maintainers poll

Are we good to transfer ownership now?

Note: Final decision is for @brancz, as he's sponsoring the repo transfer for the prometheus-community.

This temporary repo location is working. You can test it now:

$ helm repo add temp-prometheus-community https://scottrigby.github.io/prometheus-helm-charts
"temp-prometheus-community" has been added to your repositories
$ helm repo update
$ helm search repo prometheus | grep temp
temp-prometheus-community/prometheus              	11.12.1      	2.20.1     	Prometheus is a monitoring system and time seri...
temp-prometheus-community/prometheus-adapter      	2.5.1        	v0.7.0     	A Helm chart for k8s prometheus adapter           
temp-prometheus-community/prometheus-blackbox-e...	4.3.1        	0.16.0     	Prometheus Blackbox Exporter                      
temp-prometheus-community/prometheus-cloudwatch...	0.8.4        	0.8.0      	A Helm chart for prometheus cloudwatch-exporter   
temp-prometheus-community/prometheus-consul-exp...	0.1.6        	0.4.0      	A Helm chart for the Prometheus Consul Exporter   
temp-prometheus-community/prometheus-couchdb-ex...	0.1.2        	1.0        	A Helm chart to export the metrics from couchdb...
temp-prometheus-community/prometheus-mongodb-ex...	2.8.1        	v0.10.0    	A Prometheus exporter for MongoDB metrics         
temp-prometheus-community/prometheus-mysql-expo...	0.7.1        	v0.11.0    	A Helm chart for prometheus mysql exporter with...
temp-prometheus-community/prometheus-nats-exporter	2.5.1        	0.6.2      	A Helm chart for prometheus-nats-exporter         
temp-prometheus-community/prometheus-node-exporter	1.11.2       	1.0.1      	A Helm chart for prometheus node-exporter         
temp-prometheus-community/prometheus-operator     	9.3.2        	0.38.1     	DEPRECATED - This chart will be renamed. See ht...
temp-prometheus-community/prometheus-postgres-e...	1.3.1        	0.8.0      	A Helm chart for prometheus postgres-exporter     
temp-prometheus-community/prometheus-pushgateway  	1.4.2        	1.2.0      	A Helm chart for prometheus pushgateway           
temp-prometheus-community/prometheus-rabbitmq-e...	0.5.6        	v0.29.0    	Rabbitmq metrics exporter for prometheus          
temp-prometheus-community/prometheus-redis-expo...	3.5.1        	1.3.4      	Prometheus exporter for Redis metrics             
temp-prometheus-community/prometheus-snmp-exporter	0.0.6        	0.14.0     	Prometheus SNMP Exporter                          
temp-prometheus-community/prometheus-to-sd        	0.3.1        	0.5.2      	Scrape metrics stored in prometheus format and ...

After the transfer – as documented in this repo README and all the charts READMEs – you should be able to do the same with:

$ helm repo add prometheus-community https://prometheus-community.github.io/helm-charts

Is renaming prometheus-operator to kube-prometheus a blocker?

@brancz see how the temp-prometheus-community/prometheus-operator is marked DEPRECATED in the output? Because it's also flagged in Chart.yaml it will be hidden in the hubs like Helm Hub (and Artifact Hub, it's successor). I also made sure to VERY CLEARLY mark the chart README with a huge deprecation and warning sign (as well as CLI output if someone tries to install it after missing all that) so no one should mistake it as an active chart.

Regarding the order of this repo transfer and finishing fixing the renamed chart (ongoing in PR #1), I see two options:

  1. Wait to complete that until after transferring this repo to prometheus-community
    • Pro: it will allow us to deprecate the prometheus charts in the stable repo immediately, and allowing users to begin contributing directly to them
    • Con: users of stable/prometheus-operator will have to wait until the newly named prometheus-community/kube-prometheus chart is finished to use it. Then again, they will have to wait until it's ready either way
  2. Complete PR [prometheus-operator] Rename to kube-prometheus-stack #1 before transferring repo ownership to prometheus-community
    • Pro: when we announce the move, we can also announce the upgrade path from stable/prometheus-operator chart to prometheus-community/kube-prometheus
    • Con: it will delay moving the other charts. Since there are far fewer active maintainers of the stable/prometheus-operator chart it's difficult to predict a completion timeline. Also if we transferred first we could still announce the planned change (and link to the PR), which may encourage more participating in review/testing to get it done sooner than it would have otherwise?

I'm clearly in favor of option 1. Does anyone disagree?

Any other issues need to be resolved first?

All identified issues so far in this gh project prepare repo for transfer to prometheus-community/helm-charts are complete. The other open issues (apart from #13, which I'm keeping open to remind us to continue holding PRs in stable until this is done so we can close them) either must or can wait until after the transfer.

@monotek
Copy link
Member

monotek commented Aug 26, 2020

I think using "prometheus-helm-charts" as repo name makes forking easier, because there are already a lot of "Helm-Charts" repos out there..

I had a fuckup with one of these Helm-Charts repos once and had to delete & fork with other name to get it fixed.

@scottrigby
Copy link
Member Author

scottrigby commented Aug 27, 2020

@monotek I hear you, easy to rename a GitHub repo when you fork 🤷‍♂️🙂 This is ultimately what everyone does once they fork their second repo by the same name

@monotek
Copy link
Member

monotek commented Aug 28, 2020

In my case github mixed repos up, leading to a situation where I could not create prs (pr was created for another repo).
Not sure if my fault while forking or github bug (likely the first).

So maybe we could prevent such situation by using the longer name, even if it's ugly to repeate prometheus in the full repo name.

@scottrigby
Copy link
Member Author

@monotek Yes this is due to user error, and easy to fix either during forking or afterwards on your fork (https://docs.github.com/en/github/administering-a-repository/renaming-a-repository). I'll follow up with you separately.

@scottrigby
Copy link
Member Author

@scottrigby
Copy link
Member Author

See https://prometheus-community.github.io/helm-charts/index.yaml

Existing charts should now be installable per the README instructions

@monotek
Copy link
Member

monotek commented Sep 5, 2020

Sweet 😎

Maybe we should put a readme.md there to, so you get the links to the chart source if you open: https://prometheus-community.github.io

I'll create an pr later...

@monotek
Copy link
Member

monotek commented Sep 5, 2020

Done in: #39

nf-npieros pushed a commit to nf-npieros/helm-charts that referenced this issue Jan 17, 2022
* Add tolerations and node selector

* Fix PR Comments
nf-npieros pushed a commit to nf-npieros/helm-charts that referenced this issue Jan 17, 2022
* Add tolerations and node selector

* Fix PR Comments
junotx pushed a commit to junotx/prometheus-helm-charts that referenced this issue Mar 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants