-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Transfer ownership and rename scottrigby/prometheus-helm-charts to prometheus-community/helm-charts #11
Comments
I think using "prometheus-helm-charts" as repo name makes forking easier, because there are already a lot of "Helm-Charts" repos out there.. I had a fuckup with one of these Helm-Charts repos once and had to delete & fork with other name to get it fixed. |
@monotek I hear you, easy to rename a GitHub repo when you fork 🤷♂️🙂 This is ultimately what everyone does once they fork their second repo by the same name |
In my case github mixed repos up, leading to a situation where I could not create prs (pr was created for another repo). So maybe we could prevent such situation by using the longer name, even if it's ugly to repeate prometheus in the full repo name. |
@monotek Yes this is due to user error, and easy to fix either during forking or afterwards on your fork (https://docs.github.com/en/github/administering-a-repository/renaming-a-repository). I'll follow up with you separately. |
OK this is done ✅ https://github.com/prometheus-community/helm-charts |
See https://prometheus-community.github.io/helm-charts/index.yaml Existing charts should now be installable per the README instructions |
Sweet 😎 Maybe we should put a readme.md there to, so you get the links to the chart source if you open: https://prometheus-community.github.io I'll create an pr later... |
Done in: #39 |
* Add tolerations and node selector * Fix PR Comments
* Add tolerations and node selector * Fix PR Comments
clean up unused charts
Background
Fixes: prometheus-community/community#28 (comment)
Status
prometheus-operator
tokube-prometheus
a blocker?" below📊 Maintainers poll
Are we good to transfer ownership now?
Note: Final decision is for @brancz, as he's sponsoring the repo transfer for the
prometheus-community
.This temporary repo location is working. You can test it now:
After the transfer – as documented in this repo README and all the charts READMEs – you should be able to do the same with:
$ helm repo add prometheus-community https://prometheus-community.github.io/helm-charts
Is renaming
prometheus-operator
tokube-prometheus
a blocker?@brancz see how the
temp-prometheus-community/prometheus-operator
is markedDEPRECATED
in the output? Because it's also flagged inChart.yaml
it will be hidden in the hubs like Helm Hub (and Artifact Hub, it's successor). I also made sure to VERY CLEARLY mark the chart README with a huge deprecation and warning sign (as well as CLI output if someone tries to install it after missing all that) so no one should mistake it as an active chart.Regarding the order of this repo transfer and finishing fixing the renamed chart (ongoing in PR #1), I see two options:
stable
repo immediately, and allowing users to begin contributing directly to themstable/prometheus-operator
will have to wait until the newly namedprometheus-community/kube-prometheus
chart is finished to use it. Then again, they will have to wait until it's ready either waystable/prometheus-operator
chart toprometheus-community/kube-prometheus
stable/prometheus-operator
chart it's difficult to predict a completion timeline. Also if we transferred first we could still announce the planned change (and link to the PR), which may encourage more participating in review/testing to get it done sooner than it would have otherwise?I'm clearly in favor of option 1. Does anyone disagree?
Any other issues need to be resolved first?
All identified issues so far in this gh project prepare repo for transfer to prometheus-community/helm-charts are complete. The other open issues (apart from #13, which I'm keeping open to remind us to continue holding PRs in
stable
until this is done so we can close them) either must or can wait until after the transfer.The text was updated successfully, but these errors were encountered: