-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up prometheus charts issues and PRs in stable repo #29
Comments
Do we have an ETA for this? I'm still on vacation until 7. September. I try to not use the laptop and i'm only on mobile until then. Hopefully it's enough to check issues later. |
Yes the person who needs to give final approval for #11 is on vacation until this coming week |
I feel like doing the 2nd option is so tedious. Rather we can do one of the following.
|
@gkarthiks I agree, and we have already transferred the repo so we can only do option 1 now anyway 😄 I just updated the issue description. |
@scottrigby So I am going to take a stab on the Hi `uname` the `stable/chart` chart has been deprecated effectively as per this PR `deprecation_PR_in_helm/charts` on Sep 5, 2020 and moved to https://github.com/prometheus-community/helm-charts. Please close this Issue and re-open against the prometheus-community/helm-charts repo. Here's a friendly link for [new issue](https://github.com/prometheus-community/helm-charts/issues/new) We hope to see you there. 👋 does this sounds good? |
Sounds great 👍 if you get to it before each chart maintainer I'm sure they'd appreciate the extra help. Someone will have to them close those issues (I wouldn't rely on each user to do so) but that's a bit less work. Thanks! |
@scottrigby @torstenwalter I have commented in the below linked issues under helm/charts#951 helm/charts#23547 Do we expect a time line and close those issues by ourself? Like say after 15 business days? Also should we update this https://github.com/helm/charts/issues/21103 with the corresponding URLs and status as |
@gkarthiks Thanks! and yes either someone who is able (chart or repo maintainer, or the OP) can close those issues, or we can wait for stalebot to do it for us – or if not done by Nov 13th we will close all open issues when the that repo is no longer supported. I will update https://github.com/helm/charts/issues/21103 as part of #28 |
OK, all PRs and issues related to stable prometheus charts are closed with a message pointing users here ✅ |
[kube-prometheus-stack] Synchronize and upgrade kube-prometheus-stack
After #11 and #28
Note we're already holding PRs in stable (#13)
Issue options:
Automate this for users by transferring the issuestemporarily transfer repo to the helm org (because you can only move between repos within the same org)move issues fromhelm/charts
tohelm/prometheus-helm-charts
immediately transfer repo fromhelm/prometheus-helm-charts
toprometheus-community/helm-charts
Since the repo has already been transferred we can only do option 1 above.
PR options:
AFAIK there's no nice way for us to automate transferring open PRs from one repo to another and still allow the original PR author to own the PR. So I think our best option is to close open PRs in
helm/charts
with a friendly note on how they can do re-open the PR themselves (1. add new remote locally, 2. open PR from the same branch the initially did).The text was updated successfully, but these errors were encountered: