prometheus statsd exporter: migrate from niclic chart repository #372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Raymond Fallon <git@niclic.com>
Signed-off-by: Raymond Fallon <git@niclic.com>
Signed-off-by: Raymond Fallon <git@niclic.com>
Signed-off-by: Raymond Fallon <git@niclic.com>
Signed-off-by: Raymond Fallon <git@niclic.com>
Signed-off-by: Raymond Fallon <git@niclic.com>
monotek
requested changes
Nov 21, 2020
There was a problem hiding this comment.
Could you please add the git history of the old repo?
See: https://github.com/torstenwalter/helm-chart-hosting#chart-migration
|
No need to waste any more time here it seems... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Adds a prometheus-statsd-exporter chart.
Which issue this PR fixes
As per niclic/helm-charts/issues/3, this PR migrates a prometheus-statsd-exporter chart from niclic to prometheus-community.
See commit messages for details of changes made to the chart.
Special notes for your reviewer:
Future enhancements:
Currently, the ingress resource in this chart only supports exposing the
/metricsweb endpoint. There is a use case for perhaps exposing thetcpand/orudpports to enable metric collection from sources outside the kubernetes cluster. For example, see niclic/helm-charts/issues/4. However, such a change would require additional changes to support exposing TCP and UDP services.Checklist
[prometheus-couchdb-exporter])/cc @acondrat @yaron-idan @f84anton