[prometheus-statsd-exporter] add first release #449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: disorder <disordervlz@gmail.com>
|
hmm, probably the issue that helm actually does not runs without mappings specified... |
Signed-off-by: disorder <disordervlz@gmail.com>
|
Can you add yourself to CODEOWNERS file? |
torstenwalter
previously approved these changes
Dec 3, 2020
Signed-off-by: disorder <disordervlz@gmail.com>
scottrigby
requested changes
Dec 3, 2020
stats-exporter/suggestions update Co-authored-by: Scott Rigby <scott@r6by.com> Signed-off-by: disorder <disordervlz@gmail.com>
Signed-off-by: disorder <disordervlz@gmail.com>
scottrigby
approved these changes
Dec 3, 2020
scottrigby
requested changes
Dec 3, 2020
Signed-off-by: Dmitrii Limonov <disordervlz@gmail.com>
|
should we add |
|
woah, missclick |
scottrigby
previously approved these changes
Dec 4, 2020
monotek
previously approved these changes
Dec 5, 2020
|
@monotek I was just being patient waiting to see if they wanted to make a change based on my reply to their semver question. |
|
ah, ok. i was just wondering, because it was approved and not merged. so i wont merge it too :D |
Signed-off-by: Dmitrii Limonov <disordervlz@gmail.com>
Signed-off-by: Dmitrii Limonov <disordervlz@gmail.com>
Signed-off-by: Dmitrii Limonov <disordervlz@gmail.com>
Signed-off-by: Dmitrii Limonov <disordervlz@gmail.com>
|
not sure if default pathType must be |
|
|
scottrigby
reviewed
Dec 8, 2020
Signed-off-by: Dmitrii Limonov <disordervlz@gmail.com>
This was referenced Dec 18, 2020
zanhsieh
pushed a commit
that referenced
this pull request
Jan 4, 2021
* add prometheus-statsd-exporter Signed-off-by: disorder <disordervlz@gmail.com> * update default chart run Signed-off-by: disorder <disordervlz@gmail.com> * add statsd-exporter codeowners Signed-off-by: disorder <disordervlz@gmail.com> * Apply suggestions from code review stats-exporter/suggestions update Co-authored-by: Scott Rigby <scott@r6by.com> Signed-off-by: disorder <disordervlz@gmail.com> * fix README.md lints Signed-off-by: disorder <disordervlz@gmail.com> * update default ingress apiVersion Signed-off-by: Dmitrii Limonov <disordervlz@gmail.com> * add Kubernetes v19 semver ingress rules Signed-off-by: Dmitrii Limonov <disordervlz@gmail.com> * fix spaces v18 Signed-off-by: Dmitrii Limonov <disordervlz@gmail.com> * disable ingress by default Signed-off-by: Dmitrii Limonov <disordervlz@gmail.com> * set default ingress pathType Signed-off-by: Dmitrii Limonov <disordervlz@gmail.com> * set default ingress pathType to ImplementationSpecific Signed-off-by: Dmitrii Limonov <disordervlz@gmail.com> Co-authored-by: Scott Rigby <scott@r6by.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: disorder disordervlz@gmail.com
What this PR does / why we need it:
Which issue this PR fixes
(optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged)Special notes for your reviewer:
Checklist
[prometheus-couchdb-exporter])