Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[kube-prometheus-stack] Add support for alertmanager cluster.label #4877

Merged

Conversation

mfinelli
Copy link
Contributor

What this PR does / why we need it

This exposes the cluster.label option for alertmanager. This allows us to resolve prometheus/alertmanager#2250 (added in prometheus/alertmanager#3354).

The clusterLabel is supported by the CRD here: https://github.com/prometheus-community/helm-charts/blob/main/charts/prometheus-operator-crds/charts/crds/templates/crd-alertmanagers.yaml#L2094

Special notes for your reviewer

None

Checklist

  • DCO signed
  • Chart Version bumped
  • Title of the PR starts with chart name (e.g. [prometheus-couchdb-exporter])

Signed-off-by: Mario Finelli <mario@finel.li>
Copy link
Member

@jkroepke jkroepke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@jkroepke jkroepke merged commit 48bfc62 into prometheus-community:main Sep 27, 2024
4 checks passed
Madic- pushed a commit to Madic-/k3s-git-ops that referenced this pull request Oct 25, 2024
This PR contains the following updates:

| Package | Type | Update | Change | Pending |
|---|---|---|---|---|
| [kube-prometheus-stack](https://github.com/prometheus-operator/kube-prometheus) ([source](https://github.com/prometheus-community/helm-charts)) | HelmChart | major | `62.7.0` -> `63.1.0` | `64.0.0` |

---

### Release Notes

<details>
<summary>prometheus-community/helm-charts (kube-prometheus-stack)</summary>

### [`v63.1.0`](https://github.com/prometheus-community/helm-charts/releases/tag/kube-prometheus-stack-63.1.0)

[Compare Source](prometheus-community/helm-charts@kube-prometheus-stack-63.0.0...kube-prometheus-stack-63.1.0)

kube-prometheus-stack collects Kubernetes manifests, Grafana dashboards, and Prometheus rules combined with documentation and scripts to provide easy to operate end-to-end Kubernetes cluster monitoring with Prometheus using the Prometheus Operator.

#### What's Changed

-   \[kube-prometheus-stack] Add support for alertmanager cluster.label by [@&#8203;mfinelli](https://github.com/mfinelli) in prometheus-community/helm-charts#4877

#### New Contributors

-   [@&#8203;mfinelli](https://github.com/mfinelli) made their first contribution in prometheus-community/helm-charts#4877

**Full Changelog**: prometheus-community/helm-charts@kube-prometheus-stack-63.0.0...kube-prometheus-stack-63.1.0

### [`v63.0.0`](https://github.com/prometheus-community/helm-charts/releases/tag/kube-prometheus-stack-63.0.0)

[Compare Source](prometheus-community/helm-charts@kube-prometheus-stack-62.7.0...kube-prometheus-stack-63.0.0)

kube-prometheus-stack collects Kubernetes manifests, Grafana dashboards, and Prometheus rules combined with documentation and scripts to provide easy to operate end-to-end Kubernetes cluster monitoring with Prometheus using the Prometheus Operator.

#### What's Changed

-   \[kube-prometheus-stack] Add downward compat for Prom CRD by [@&#8203;schnatterer](https://github.com/schnatterer) in prometheus-community/helm-charts#4818

#### New Contributors

-   [@&#8203;schnatterer](https://github.com/schnatterer) made their first contribution in prometheus-community/helm-charts#4818

**Full Changelog**: prometheus-community/helm-charts@prometheus-conntrack-stats-exporter-0.5.11...kube-prometheus-stack-63.0.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40NDAuNyIsInVwZGF0ZWRJblZlciI6IjM3LjQ0MC43IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119-->

Reviewed-on: https://code.geekbundle.org/madic/git-ops-dev/pulls/174
Co-authored-by: renovate Bot <renovate@geekbundle.org>
Co-committed-by: renovate Bot <renovate@geekbundle.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Kubernetes] Peers ip caching causes all clusters to degrade over time
2 participants