Cluster: Add memberlist label configuration option #3354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jean-Philippe Quémémer <jeanphilippe.quemener@grafana.com>
gotjosh
reviewed
May 5, 2023
Co-authored-by: gotjosh <josue.abreu@gmail.com> Signed-off-by: Jean-Philippe Quéméner <JohnnyQQQQ@users.noreply.github.com>
JohnnyQQQQ
commented
May 5, 2023
Signed-off-by: Jean-Philippe Quéméner <JohnnyQQQQ@users.noreply.github.com>
JohnnyQQQQ
commented
May 5, 2023
Signed-off-by: Jean-Philippe Quéméner <JohnnyQQQQ@users.noreply.github.com>
|
Thank you very much for your contribution! |
qinxx108
pushed a commit
to qinxx108/alertmanager
that referenced
this pull request
Jun 6, 2023
* Cluster: Add memberlist label configuration option Signed-off-by: Jean-Philippe Quémémer <jeanphilippe.quemener@grafana.com> --------- Signed-off-by: Jean-Philippe Quémémer <jeanphilippe.quemener@grafana.com> Signed-off-by: Jean-Philippe Quéméner <JohnnyQQQQ@users.noreply.github.com> Co-authored-by: gotjosh <josue.abreu@gmail.com> Signed-off-by: Yijie Qin <qinyijie@amazon.com>
qinxx108
pushed a commit
to qinxx108/alertmanager
that referenced
this pull request
Jul 5, 2023
* Cluster: Add memberlist label configuration option Signed-off-by: Jean-Philippe Quémémer <jeanphilippe.quemener@grafana.com> --------- Signed-off-by: Jean-Philippe Quémémer <jeanphilippe.quemener@grafana.com> Signed-off-by: Jean-Philippe Quéméner <JohnnyQQQQ@users.noreply.github.com> Co-authored-by: gotjosh <josue.abreu@gmail.com> Signed-off-by: Yijie Qin <qinyijie@amazon.com>
gotjosh
added a commit
that referenced
this pull request
Aug 7, 2023
* Cluster: Add memberlist label configuration option Signed-off-by: Jean-Philippe Quémémer <jeanphilippe.quemener@grafana.com> --------- Signed-off-by: Jean-Philippe Quémémer <jeanphilippe.quemener@grafana.com> Signed-off-by: Jean-Philippe Quéméner <JohnnyQQQQ@users.noreply.github.com> Co-authored-by: gotjosh <josue.abreu@gmail.com>
3 tasks
This was referenced Sep 26, 2023
radek-ryckowski
pushed a commit
to goldmansachs/alertmanager
that referenced
this pull request
Nov 6, 2023
* Cluster: Add memberlist label configuration option Signed-off-by: Jean-Philippe Quémémer <jeanphilippe.quemener@grafana.com> --------- Signed-off-by: Jean-Philippe Quémémer <jeanphilippe.quemener@grafana.com> Signed-off-by: Jean-Philippe Quéméner <JohnnyQQQQ@users.noreply.github.com> Co-authored-by: gotjosh <josue.abreu@gmail.com>
qinxx108
pushed a commit
to amazon-contributing/alertmanager
that referenced
this pull request
Mar 28, 2024
* Cluster: Add memberlist label configuration option Signed-off-by: Jean-Philippe Quémémer <jeanphilippe.quemener@grafana.com> --------- Signed-off-by: Jean-Philippe Quémémer <jeanphilippe.quemener@grafana.com> Signed-off-by: Jean-Philippe Quéméner <JohnnyQQQQ@users.noreply.github.com> Co-authored-by: gotjosh <josue.abreu@gmail.com>
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes it possible to set a label for the Memberlist cluster. This label is used to block any traffic that is not meant for the cluster.
For instance, in a situation where there are multiple alertmanager clusters, such as in K8s where IP addresses are shared and reused throughout the cluster, this label helps to prevent a wrong alertmanager cluster from receiving traffic meant for another cluster.