Add connection limits metrics for pg_roles and pg_database #997
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jocelynthode
force-pushed
the
add-connection-limit
branch
from
6fb5b0f to
f5ab218
Compare
SuperQ
reviewed
Jan 16, 2024
jocelynthode
force-pushed
the
add-connection-limit
branch
from
f5ab218 to
8a549d9
Compare
|
@SuperQ: Hey, could you review my latest changes please? :) |
SuperQ
reviewed
Jan 23, 2024
jocelynthode
force-pushed
the
add-connection-limit
branch
from
8a549d9 to
fafc274
Compare
Signed-off-by: Jocelyn Thode <jocelyn@thode.email>
Signed-off-by: Jocelyn Thode <jocelyn@thode.email>
jocelynthode
force-pushed
the
add-connection-limit
branch
from
fafc274 to
20dc930
Compare
sysadmind
requested changes
Jan 23, 2024
Co-authored-by: Joe Adams <github@joeadams.io> Signed-off-by: Jocelyn Thode <jocelynthode@users.noreply.github.com>
Co-authored-by: Joe Adams <github@joeadams.io> Signed-off-by: Jocelyn Thode <jocelynthode@users.noreply.github.com>
Co-authored-by: Joe Adams <github@joeadams.io> Signed-off-by: Jocelyn Thode <jocelynthode@users.noreply.github.com>
jocelynthode
force-pushed
the
add-connection-limit
branch
from
0687481 to
b131dc5
Compare
Signed-off-by: Jocelyn Thode <jocelyn@thode.email>
jocelynthode
force-pushed
the
add-connection-limit
branch
from
b131dc5 to
95ef252
Compare
sysadmind
approved these changes
Jan 24, 2024
|
@SuperQ any update on this PR? |
|
@sysadmind Is there something I can do to get this PR moving forward? I'm looking forward to be able to use these new metrics. |
|
It will be available in master. I'm not sure when the next release will be. I haven't had much time recently so I haven't been able to work on this project. |
|
Thanks for the work you do on this project it's much appreciated :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #996
This PR adds the possibility to gather metrics for Database and roles connection limits.