Convert the tcp collector to use perflib and support TCPv6 counters #615
Conversation
Using perflib is substantially faster and more reliable than using WMI to retrieve Windows performance counter data. Signed-off-by: Michael Allen <MAllen@laserfiche.com>
|
I also have a commit in my local tree to write TCPv6 counters with labels af="ipv4" and af="ipv6" to distinguish between the TCPv4 and TCPv6 performance objects. However, this would be an incompatible change so I decided to leave it out of this PR. But I can push that commit if interested. |
Signed-off-by: Michael Allen <MAllen@laserfiche.com>
|
Nice @mallenLF! Regarding TCPv6, I'm fine with adding that in as well with the label. It'll make the results more precise, and those who need to distinguish between protocols can then do so. |
Note that TCPv6 metrics are now exported, and there is a new label, `af`. Signed-off-by: Michael Allen <MAllen@laserfiche.com>
mallenLF
changed the title
I pushed commits to export the TCPv6 counters and to update the docs for the tcp collector. |
Convert the tcp collector to use perflib and support TCPv6 counters
Using perflib is substantially faster and more reliable than using WMI to
retrieve Windows performance counter data.
TCP over IPv6 is distinguished from IPv4 traffic by means of an "af" label
to denote the address family, which will be "ipv4" for TCP over IPv4,
corresponding to the TCPv4 performance object, and "ipv6" for TCP over
IPv6, corresponding to the TCPv6 performance object.
Signed-off-by: Michael Allen MAllen@laserfiche.com