Add PagerDuty source field (PD-CEF) #3100
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
thanks! @EronWright since you've filed the original issue, does it look like the right approach for you?
notify/pagerduty/pagerduty.go
Outdated
Comment on lines
213
to
215
| if n.conf.Source != "" { | ||
| payloadSource = n.conf.Source | ||
| } |
There was a problem hiding this comment.
The default value could be handled in config/notifiers.go when unmarshaling the YAML data. This would be more explicit when users look at the /api/v2/status endpoint.
added 2 commits
October 12, 2022 11:11
Signed-off-by: Oktarian Tilney-Bassett <oktariantilneybassett@improbable.io>
Signed-off-by: Oktarian Tilney-Bassett <oktariantilneybassett@improbable.io>
|
Can you sign your commits? the easiest solution is probably to squash all the commits: |
added 7 commits
October 13, 2022 11:16
Signed-off-by: Oktarian Tilney-Bassett <oktariantilneybassett@improbable.io>
…anager into pagerduty-source-field
Signed-off-by: Oktarian Tilney-Bassett <oktariantilneybassett@improbable.io>
Signed-off-by: Oktarian Tilney-Bassett <oktariantilneybassett@improbable.io>
…anager into pagerduty-source-field
|
I opened a new PR with the signing properly setup: #3106 - sorry! |
|
No problem! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #3079 by adding a new
sourcefield to the PagerDuty config. Maintains backward compatibility by defaulting to theclientfield. Added some tests to ensure behaviour works as expected now and in the future. Updated docs as well.this is my first ever open source contribution! #hacktoberfest