Add PagerDuty source field (PD-CEF) #3106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 13, 2022 12:11
Signed-off-by: Oktarian Tilney-Bassett <oktariantilneybassett@improbable.io>
Signed-off-by: Oktarian Tilney-Bassett <oktariantilneybassett@improbable.io>
qinxx108
pushed a commit
to qinxx108/alertmanager
that referenced
this pull request
Nov 16, 2022
* Add new source field to PD config * Update documentation Signed-off-by: Oktarian Tilney-Bassett <oktariantilneybassett@improbable.io> Signed-off-by: Yijie Qin <qinyijie@amazon.com>
qinxx108
pushed a commit
to qinxx108/alertmanager
that referenced
this pull request
Dec 13, 2022
* Add new source field to PD config * Update documentation Signed-off-by: Oktarian Tilney-Bassett <oktariantilneybassett@improbable.io> Signed-off-by: Yijie Qin <qinyijie@amazon.com>
|
Hi @OktarianTB @simonpasquier @qinxx108 , thanks for implementing these. I tried to add both I'm using Alertmanager v0.27.0 
Is this working or did I miss anything ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #3079 by adding a new
sourcefield to the PagerDuty config. Maintains backward compatibility by defaulting to theclientfield. Added some tests to ensure behaviour works as expected now and in the future. Updated docs as well.Had to close previous PR after messing up the signing.
Signed-off-by: Oktarian Tilney-Bassett oktariantilneybassett@improbable.io