Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sanitize invalid UTF-8 #968

Merged
merged 1 commit into from
Aug 27, 2023
Merged

Sanitize invalid UTF-8 #968

merged 1 commit into from
Aug 27, 2023

Conversation

SuperQ
Copy link
Member

@SuperQ SuperQ commented Aug 27, 2023

Avoid sending raw invalid UTF-8 to metrics by replacing invalid chars with U+FFFD.

Fixes: #279

@SuperQ
Sanitize invalid UTF-8
25a8843 
Avoid sending raw invalid UTF-8 to metrics by replacing invalid chars
with U+FFFD.

Fixes: #279

Signed-off-by: SuperQ <superq@gmail.com>
@SuperQ SuperQ requested a review from RichiH August 27, 2023 14:17
@SuperQ
Copy link
Member Author

SuperQ commented Aug 27, 2023

👓 @dswarbrick

@SuperQ
Copy link
Member Author

SuperQ commented Aug 27, 2023

Sigh:

ERROR: cannot verify file.wiener-d.com's certificate, issued by ‘CN=RapidSSL Global TLS RSA4096 SHA256 2022 CA1,O=DigiCert\\, Inc.,C=US’:
  Issued certificate has expired.

@SuperQ SuperQ merged commit a42276b into main Aug 27, 2023
@SuperQ SuperQ deleted the superq/sanitize_strings branch August 27, 2023 15:23
SuperQ added a commit that referenced this pull request Aug 29, 2023
@SuperQ
Release v0.24.0
850cc25 
* [CHANGE] Sanitize invalid UTF-8 #968
* [FEATURE] Support fetching multiple modules in one scrape #945
* [FEATURE] Support loading multiple configuration files #970

Signed-off-by: SuperQ <superq@gmail.com>
@SuperQ SuperQ mentioned this pull request Aug 29, 2023
Merged
SuperQ added a commit that referenced this pull request Aug 29, 2023
@SuperQ
Release v0.24.0 (#974)
c9fd025 
* [CHANGE] Sanitize invalid UTF-8 #968
* [FEATURE] Support fetching multiple modules in one scrape #945
* [FEATURE] Support loading multiple configuration files #970

Signed-off-by: SuperQ <superq@gmail.com>
stephan-windischmann-sky pushed a commit to stephan-windischmann-sky/snmp_exporter that referenced this pull request Oct 27, 2023
@SuperQ
Sanitize invalid UTF-8 (prometheus#968)
d931e36 
Avoid sending raw invalid UTF-8 to metrics by replacing invalid chars
with U+FFFD.

Fixes: prometheus#279

Signed-off-by: SuperQ <superq@gmail.com>
Signed-off-by: Stephan Windischmann <windi@Stephans-MacBook-Pro.local>
stephan-windischmann-sky pushed a commit to stephan-windischmann-sky/snmp_exporter that referenced this pull request Oct 27, 2023
@SuperQ
Release v0.24.0 (prometheus#974)
1ef7b88 
* [CHANGE] Sanitize invalid UTF-8 prometheus#968
* [FEATURE] Support fetching multiple modules in one scrape prometheus#945
* [FEATURE] Support loading multiple configuration files prometheus#970

Signed-off-by: SuperQ <superq@gmail.com>
Signed-off-by: Stephan Windischmann <windi@Stephans-MacBook-Pro.local>
@LeSuisse LeSuisse mentioned this pull request Jan 14, 2024
Merged
@SuperQ SuperQ mentioned this pull request May 11, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RichiH RichiH RichiH approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

invalid character on device description passes from snmp_exporter to prometheus - invalid utf-8 label
2 participants
@SuperQ @RichiH