-
Notifications
You must be signed in to change notification settings - Fork 634
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support loading multiple configuration files #970
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SuperQ
force-pushed
the
superq/multi_config
branch
from
August 27, 2023 16:21
a4c4a38
to
da55a14
Compare
Support loading multiple configuration files by by allowing `--config.file` to be repeateable. As well as supporting glob file matching for `config.d` style setups. * Conflicting auth or module keys are treated as errors. Fixes: #628 Signed-off-by: SuperQ <superq@gmail.com>
SuperQ
force-pushed
the
superq/multi_config
branch
from
August 27, 2023 16:22
da55a14
to
266b98b
Compare
RichiH
approved these changes
Aug 28, 2023
Signed-off-by: Ben Kochie <superq@gmail.com> Co-authored-by: Richard Hartmann <RichiH@users.noreply.github.com> Signed-off-by: Ben Kochie <superq@gmail.com>
Merged
SuperQ
added a commit
that referenced
this pull request
Aug 29, 2023
stephan-windischmann-sky
pushed a commit
to stephan-windischmann-sky/snmp_exporter
that referenced
this pull request
Oct 27, 2023
* Support loading multiple configuration files Support loading multiple configuration files by by allowing `--config.file` to be repeateable. As well as supporting glob file matching for `config.d` style setups. * Conflicting auth or module keys are treated as errors. Fixes: prometheus#628 --------- Signed-off-by: SuperQ <superq@gmail.com> Signed-off-by: Ben Kochie <superq@gmail.com> Co-authored-by: Richard Hartmann <RichiH@users.noreply.github.com> Signed-off-by: Stephan Windischmann <windi@Stephans-MacBook-Pro.local>
stephan-windischmann-sky
pushed a commit
to stephan-windischmann-sky/snmp_exporter
that referenced
this pull request
Oct 27, 2023
* [CHANGE] Sanitize invalid UTF-8 prometheus#968 * [FEATURE] Support fetching multiple modules in one scrape prometheus#945 * [FEATURE] Support loading multiple configuration files prometheus#970 Signed-off-by: SuperQ <superq@gmail.com> Signed-off-by: Stephan Windischmann <windi@Stephans-MacBook-Pro.local>
4 tasks
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support loading multiple configuration files by by allowing
--config.file
to be repeateable. As well as supporting glob file matching forconfig.d
style setups.Fixes: #628