-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate to Poetry v2 and project-managed Poetry plugins #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 6, 2025
I opened poetry-dynamic-versioning issue #203 to report a minor formatting issue in |
I opened poetry issue #9975, because I noticed that Poetry now removes installed extras when adding a new dependency, which surprised me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Poetry v2.0.0 was released on Jan 5. This is a major version, with some interface changes both in the Poetry command line and in the format of
pyproject.toml
. It also supports a feature I've been wanting for a long time, project plugins managed inpyproject.toml
. This will let me use poetry-dynamic-versioning as a project plugin.Most of the work here was in rewriting
pyproject.toml
to follow the new standard from PEP-621. After doing this, I confirmed that the generated artifacts indist
(created viarun build
) had only minor, explainable differences. This gave me confidence that the old and new versions ofpyproject.toml
were equivalent.Since I was rewriting
pyproject.toml
anyway, I took the opportunity to move configuration for pytest, mypy, and coverage out of individual files like.mypy.ini
and intopyproject.toml
instead.The
poetry install --sync
command is deprecated, so I updatedcommands/virtualenv.sh
in run-script-framework to usepoetry sync
instead. I also made some other minor adjustments to the run script framework to ensure I got the intended behavior from some Poetry commands.Now that project plugins are available, I was able to simplify the shared GitHub actions and workflows, which no longer need to be aware of plugins at all (see setup-poetry and gha-shared-workflows).
I also made changes in the cookiecutter-pypi template based on the work prototyped here.