Finalize trigger enables propagation if it was stopped

[prolic]

superseeds #183

/cc @UFOMelkor

[coveralls]

Coverage remained the same at 100.0% when pulling 3396f96 on fix-route-guard into a9b0a7e on master.

[UFOMelkor]

Please give me 2 hours to evaluate another test case that came to my mind.

[UFOMelkor]

If I understand the logic of the finalize event correct, It's listeners should be always called. This would not be the case if the propagation is stopped but no exception has been thrown, only the first finalize listener is called:

    /**
     * @test
     */
    public function it_always_triggers_finalize_listeners_regardless_whether_the_propagation_of_the_event_has_been_stopped(): void
    {
        $messageBus = new CommandBus();

        $messageBus->attach(CommandBus::EVENT_DISPATCH, function (ActionEvent $event) {
            $event->setParam(CommandBus::EVENT_PARAM_MESSAGE_HANDLER, function () {
            });
        }, CommandBus::PRIORITY_LOCATE_HANDLER+1);
        $messageBus->attach(CommandBus::EVENT_DISPATCH, function (ActionEvent $event) {
            $event->stopPropagation();
        }, CommandBus::PRIORITY_INVOKE_HANDLER-1);

        $messageBus->attach(MessageBus::EVENT_FINALIZE, function () {
        }, 3);
        $finalizeHasBeenCalled = false;
        $messageBus->attach(MessageBus::EVENT_FINALIZE, function () use (&$finalizeHasBeenCalled) {
            $finalizeHasBeenCalled = true;
        }, 2);

        $messageBus->dispatch('a message');

        self::assertTrue($finalizeHasBeenCalled);
    }

If my assumption is correct, additional tests for the CommandBus, EventBus and QueryBus are necessary and the triggerFinalize method should be like

protected function triggerFinalize(ActionEvent $actionEvent): void
    {
        $actionEvent->setName(self::EVENT_FINALIZE);
        $actionEvent->stopPropagation(false);

        $this->events->dispatch($actionEvent);
    }

[prolic]

@UFOMelkor I added further tests

[UFOMelkor]

In my understanding the tests must not fail without these three exceptions (and currently they would fail).

[UFOMelkor]

3

[UFOMelkor]

2

[UFOMelkor]

1

[prolic]

@UFOMelkor You're right, fixed!

[UFOMelkor]

LGTM 👍