Finalize trigger enables propagation if it was stopped

src/QueryBus.php

@@ -104,7 +104,7 @@ public function dispatch($query): PromiseInterface
             }
         } catch (\Throwable $exception) {
             $actionEvent->setParam(self::EVENT_PARAM_EXCEPTION, $exception);
-            //$actionEvent->stopPropagation(false);
+            $actionEvent->stopPropagation(false);
         } finally {
             $this->triggerFinalize($actionEvent);
         }

tests/CommandBusTest.php

@@ -295,4 +295,34 @@ public function it_passes_queued_commands_to_command_dispatch_exception_in_case_
         $this->assertSame(1, count($commandDispatchException->getPendingCommands()));
         $this->assertSame(CustomMessage::class, get_class($commandDispatchException->getPendingCommands()[0]));
     }
+
+    /**
+     * @test
+     */
+    public function it_always_triggers_finalize_listeners_regardless_whether_the_propagation_of_the_event_has_been_stopped(): void
+    {
+        $this->commandBus->attach(CommandBus::EVENT_DISPATCH, function (ActionEvent $event) {
+            $event->setParam(CommandBus::EVENT_PARAM_MESSAGE_HANDLER, function (): void {
+            });
+        }, CommandBus::PRIORITY_LOCATE_HANDLER + 1);
+        $this->commandBus->attach(CommandBus::EVENT_DISPATCH, function (ActionEvent $event): void {
+            $event->stopPropagation();
+            throw new \RuntimeException('boom');
+        }, CommandBus::PRIORITY_INVOKE_HANDLER - 1);
+
+        $this->commandBus->attach(MessageBus::EVENT_FINALIZE, function (): void {
+        }, 3);
+        $finalizeHasBeenCalled = false;
+        $this->commandBus->attach(MessageBus::EVENT_FINALIZE, function () use (&$finalizeHasBeenCalled): void {
+            $finalizeHasBeenCalled = true;
+        }, 2);
+
+        try {
+            $this->commandBus->dispatch('a message');
+        } catch (\Throwable $e) {
+            // ignore
+        }
+
+        $this->assertTrue($finalizeHasBeenCalled);
+    }
 }

tests/EventBusTest.php

@@ -305,4 +305,34 @@ function (ActionEvent $actionEvent) use (&$finalizeIsTriggered, &$listenerExcept
         $this->assertSame($customMessage, $handler->getLastMessage());
         $this->assertEquals(2, $handler->getInvokeCounter());
     }
+
+    /**
+     * @test
+     */
+    public function it_always_triggers_finalize_listeners_regardless_whether_the_propagation_of_the_event_has_been_stopped(): void
+    {
+        $this->eventBus->attach(EventBus::EVENT_DISPATCH, function (ActionEvent $event) {
+            $event->setParam(EventBus::EVENT_PARAM_MESSAGE_HANDLER, function (): void {
+            });
+        }, EventBus::PRIORITY_LOCATE_HANDLER + 1);
+        $this->eventBus->attach(EventBus::EVENT_DISPATCH, function (ActionEvent $event): void {
+            $event->stopPropagation();
+            throw new \RuntimeException('boom');
+        }, EventBus::PRIORITY_INVOKE_HANDLER - 1);
+
+        $this->eventBus->attach(MessageBus::EVENT_FINALIZE, function (): void {
+        }, 3);
+        $finalizeHasBeenCalled = false;
+        $this->eventBus->attach(MessageBus::EVENT_FINALIZE, function () use (&$finalizeHasBeenCalled): void {
+            $finalizeHasBeenCalled = true;
+        }, 2);
+
+        try {
+            $this->eventBus->dispatch('a message');
+        } catch (\Throwable $e) {
+            // ignore
+        }
+
+        $this->assertTrue($finalizeHasBeenCalled);
+    }
 }

tests/Plugin/MessageFactoryPluginTest.php

@@ -73,7 +73,6 @@ function (ActionEvent $actionEvent): void {
 
     /**
      * @test
-     * @group by
      */
     public function it_will_return_early_if_message_name_not_present_in_message(): void
     {

tests/QueryBusTest.php

@@ -352,4 +352,30 @@ function (ActionEvent $actionEvent) use (&$exceptionParamWasSet): void {
 
         $this->assertTrue($exceptionParamWasSet);
     }
+
+    /**
+     * @test
+     */
+    public function it_always_triggers_finalize_listeners_regardless_whether_the_propagation_of_the_event_has_been_stopped(): void
+    {
+        $this->queryBus->attach(QueryBus::EVENT_DISPATCH, function (ActionEvent $event) {
+            $event->setParam(QueryBus::EVENT_PARAM_MESSAGE_HANDLER, function (): void {
+            });
+        }, QueryBus::PRIORITY_LOCATE_HANDLER + 1);
+        $this->queryBus->attach(QueryBus::EVENT_DISPATCH, function (ActionEvent $event): void {
+            $event->stopPropagation();
+            throw new \RuntimeException('boom');
+        }, QueryBus::PRIORITY_INVOKE_HANDLER - 1);
+
+        $this->queryBus->attach(MessageBus::EVENT_FINALIZE, function (): void {
+        }, 3);
+        $finalizeHasBeenCalled = false;
+        $this->queryBus->attach(MessageBus::EVENT_FINALIZE, function () use (&$finalizeHasBeenCalled): void {
+            $finalizeHasBeenCalled = true;
+        }, 2);
+
+        $this->queryBus->dispatch('a message');
+
+        $this->assertTrue($finalizeHasBeenCalled);
+    }
 }