Skip to content

Commit

Permalink
Update default dependency for gtest. (#7907)
Browse files Browse the repository at this point in the history
The gtest source was changed in #7237 on an opt-in basis, and has been
released since 3.12.0. The comments state that the default should change
in 3.13.0, but that didn't quite happen.

This change does flip the default, and updates comments to say 3.14.0.
  • Loading branch information
dlj-NaN authored Oct 3, 2020
1 parent ad29d40 commit f5a3b92
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
4 changes: 2 additions & 2 deletions BUILD
Original file line number Diff line number Diff line change
Expand Up @@ -14,10 +14,10 @@ exports_files(["LICENSE"])
# build configuration
################################################################################

# TODO(yannic): Remove in 3.14.0.
string_flag(
name = "incompatible_use_com_google_googletest",
# TODO(yannic): Flip to `true` for `3.13.0`.
build_setting_default = "false",
build_setting_default = "true",
values = ["true", "false"]
)

Expand Down
4 changes: 2 additions & 2 deletions WORKSPACE
Original file line number Diff line number Diff line change
Expand Up @@ -29,13 +29,13 @@ bind(
actual = "//util/python:python_headers",
)

# TODO(yannic): Remove in 3.13.0.
# TODO(yannic): Remove in 3.14.0.
bind(
name = "gtest",
actual = "@com_google_googletest//:gtest",
)

# TODO(yannic): Remove in 3.13.0.
# TODO(yannic): Remove in 3.14.0.
bind(
name = "gtest_main",
actual = "@com_google_googletest//:gtest_main",
Expand Down

0 comments on commit f5a3b92

Please sign in to comment.