[bazel] Update gtest and deprecate //external:{gtest,gtest_main} #7237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change updates the gtest-version used by Bazel.
Also, `//external:{gtest,gtest_main}` is deprecated so we can remove some
of the uses of the discouraged `bind` function.
RELNOTES[bazel]: Starting with Protobuf 3.13.0, building and running
Protobuf tests requires `@com_google_googletest//:{gtest,gtest_main}`
instead of `//external:{gtest,gtest_main}`. Use
`--@com_google_protobuf//:incompatible_use_com_google_googletest=true`
to verify your workspace is not affected by this change.
|
Note that this only changes the gtest version for Bazel. Other builds still use the submodule. Updating the submodules isn't possible because gtest removed support for autotools (#6590). |
|
@rafi-kamal Thanks for your review! As usual, |
|
I think that sounds good, I've sent out #7275. |
rafi-kamal
approved these changes
Mar 2, 2020
dlj-NaN
added a commit
to dlj-NaN/protobuf
that referenced
this pull request
Sep 23, 2020
The gtest source was changed in protocolbuffers#7237 on an opt-in basis, and has been released since 3.12.0. The comments state that the default should change in 3.13.0, but that didn't quite happen. This change does flip the default, and updates comments to say 3.14.0.
This was referenced Sep 23, 2020
Closed
dlj-NaN
added a commit
to dlj-NaN/protobuf
that referenced
this pull request
Oct 2, 2020
The gtest source was changed in protocolbuffers#7237 on an opt-in basis, and has been released since 3.12.0. The comments state that the default should change in 3.13.0, but that didn't quite happen. This change does flip the default, and updates comments to say 3.14.0.
dlj-NaN
added a commit
that referenced
this pull request
Oct 3, 2020
The gtest source was changed in #7237 on an opt-in basis, and has been released since 3.12.0. The comments state that the default should change in 3.13.0, but that didn't quite happen. This change does flip the default, and updates comments to say 3.14.0.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change updates the gtest-version used by Bazel.
Also,
//external:{gtest,gtest_main}is deprecated so we can remove someof the uses of the discouraged
bindfunction.RELNOTES[bazel]: Starting with Protobuf 3.13.0, building and running
Protobuf tests requires
@com_google_googletest//:{gtest,gtest_main}instead of
//external:{gtest,gtest_main}. Use--@com_google_protobuf//:incompatible_use_com_google_googletest=trueto verify your workspace is not affected by this change.