Update GoogleTest #6590
Closed
Update GoogleTest #6590
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Yannic It looks like this somehow causes |
|
Seems like |
|
That's interesting, we have also been thinking about removing our autotools build support (#5124). |
|
Let me go ahead and close this. I appreciate the change and it would be great to upgrade GoogleTest, but unfortunately we can't do that until we figure out a solution for autotools support (which has been removed in recent GoogleTest versions). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates GoogleTest to include load statements for
@rules_cc, which will be required by a future version of Bazel.