Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI "Check for Safety" provide no actionable feedback. #15847

Closed
bcsgh opened this issue Feb 15, 2024 · 1 comment · Fixed by #15892
Closed

CI "Check for Safety" provide no actionable feedback. #15847

bcsgh opened this issue Feb 15, 2024 · 1 comment · Fixed by #15892
Assignees
@acozzette

Comments

@bcsgh
Copy link
Contributor

bcsgh commented Feb 15, 2024

What version of protobuf and what language are you using?

Current main branch

What operating system (Linux, Windows, ...) and version?

GitHub's CI

What runtime / compiler are you using (e.g., python version or gcc version)

Not relevent?

What did you do?
Steps to reproduce the behavior:

  1. Create a random fork as a random contributor and do something in a new branch.
  2. Create a draft merge request.
  3. Look at the Action the merge requests kicks off
  4. See This pull request is from an unsafe fork and hasn't been approved to run tests! without even a link to what to do about that.

What did you expect to see

A message that says what to do.

What did you see instead?

A non-actionable message. (It does at least say what's wrong, jut not what to do next.)
@bcsgh bcsgh added the untriaged auto added to all issues by default when created. label Feb 15, 2024
@bcsgh bcsgh mentioned this issue Feb 15, 2024
Closed
@googleberg googleberg removed the untriaged auto added to all issues by default when created. label Feb 17, 2024
@googleberg
Copy link
Member

@acozzette Can you see if this message is customizable?

copybara-service bot pushed a commit that referenced this issue Feb 20, 2024
@acozzette @copybara-github
Update error message to clarify what needs to happen for tests to run
66ad30f 
When we get a pull request from outside the protobuf repository, the tests will
not run until a protobuf team member adds the `safe for tests` tag. This change
updates the error message to make it more clear what has to happen to get the
tests to run.

Fixes #15847.

PiperOrigin-RevId: 608648079
@copybara-service copybara-service bot mentioned this issue Feb 20, 2024
Merged
copybara-service bot pushed a commit that referenced this issue Feb 20, 2024
@acozzette @copybara-github
Update error message to clarify what needs to happen for tests to run
b5dc230 
When we get a pull request from outside the protobuf repository, the tests will
not run until a protobuf team member adds the `safe for tests` tag. This change
updates the error message to make it more clear what has to happen to get the
tests to run.

Fixes #15847.

PiperOrigin-RevId: 608648079
deannagarcia pushed a commit to deannagarcia/protobuf that referenced this issue Jun 20, 2024
@acozzette @deannagarcia
Update error message to clarify what needs to happen for tests to run
2d5102c 
When we get a pull request from outside the protobuf repository, the tests will
not run until a protobuf team member adds the `safe for tests` tag. This change
updates the error message to make it more clear what has to happen to get the
tests to run.

Fixes protocolbuffers#15847.

PiperOrigin-RevId: 608660908
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@acozzette acozzette

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update error message to clarify what needs to happen for tests to run protocolbuffers/protobuf
3 participants
@acozzette @bcsgh @googleberg