Avoid a 'may be used uninitialized' warning when built with '-c opt'. #15846
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…(that could result in a non-null garbage pointer).
|
Because the CI refuses to run (and refuses to tell me what to do about that #15847) I have no idea if this is ready for review yet so I'll just kick it out and see what happens. |
fowles
approved these changes
Feb 15, 2024
github-actions
bot
removed
the
🅰️ safe for tests
|
@fowles so which presubmit did I break internally? |
It got hung up on something silly and I had to give it kick. Hopefully it goes through smoothly in the next couple hours. |
deannagarcia
pushed a commit
to deannagarcia/protobuf
that referenced
this pull request
Jun 20, 2024
…protocolbuffers#15846) The motivation for this is first that under some combinations of flags it breaks builds and second it's trivial (and possibly zero runtime cost) to fix. It looks like the possibly bad case "should never happen", but converting this to a null pointer in the error case (which should at least make the failure less problematic) is cheap. Closes protocolbuffers#15846 COPYBARA_INTEGRATE_REVIEW=protocolbuffers#15846 from bcsgh:bcsgh/uninitialized 321d649 PiperOrigin-RevId: 607404168
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The motivation for this is first that under some combinations of flags it breaks builds and second it's trivial (and possibly zero runtime cost) to fix.
It looks like the possibly bad case "should never happen", but converting this to a null pointer in the error case (which should at least make the failure less problematic) is cheap.