Ruby FFI implementation #13343
Closed
Ruby FFI implementation #13343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ble to handle FFI.
…ies on Ruby headers from functionality needed by FFI.
…ies on Ruby headers from functionality needed by FFI.
Add `ifndef` armor around shared_convert.h.
…ry and protoc outputs instead.
… FFI. Normalize on ext/google/protobuf_c/third_party/utf8_range as the expected directory. Calculate relative paths in ffi.rake rather than include multiple options. Make `rake clean` remove third_party and other artifacts.
That look a lot more experimentation and fixing than anticipated, but all Ruby tests pass now. The breakage of the Java tests is unrelated - they're currently broken at HEAD, too. |
mkruskal-google
approved these changes
Jul 21, 2023
haberman
requested changes
Jul 21, 2023
haberman
approved these changes
Jul 21, 2023
JasonLunn
added
🅰️ safe for tests
Consistently use `.by_ref` in function signatures that accept an Arena.
…truct." This reverts commit e5cd20f
mkruskal-google
approved these changes
Jul 24, 2023
esorot
added
🅰️ safe for tests
CareF
reviewed
Oct 17, 2023
| @@ -110,8 +110,8 @@ def protobuf_deps(): | |||
| _github_archive( | |||
| name = "rules_ruby", | |||
| repo = "https://github.com/protocolbuffers/rules_ruby", | |||
| commit = "8fca842a3006c3d637114aba4f6bf9695bb3a432", | |||
| sha256 = "2619f9a23cee6f6a198d9ef284b6f6cbc901545ee9a9aac9ffa6b83dbf17cf0c", | |||
| commit = "b7f3e9756f3c45527be27bc38840d5a1ba690436", | |||
There was a problem hiding this comment.
protocolbuffers/rules_ruby@b7f3e97 shows
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
It seems this commit is not part of the main branch is has been deleted
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes #11483.