Add disallowment of setting numpy singleton arrays and multi-dimensio… #9788
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nal arrays to fields/repeated fields to CHANGES.txt, which was missed in a previous git sync
fowles
reviewed
Apr 14, 2022
CHANGES.txt
Outdated
| @@ -73,6 +73,8 @@ | |||
| JSON serializations with UTF-8 or other non-ASCII encodings. | |||
| * Added experimental support for directly assigning numpy scalars and array. | |||
| * Improve the calculation of public_dependencies in DescriptorPool. | |||
| * Disallow setting fields to numpy singleton arrays or repeated fields to numpy | |||
| multi-dimensional arrays. | |||
There was a problem hiding this comment.
can you call out more clearly that this is a breaking change and what the solution is?
There was a problem hiding this comment.
Done. Also fixed in release notes.
fowles
approved these changes
Apr 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add disallowment of setting numpy singleton arrays and multi-dimensional arrays to fields/repeated fields to CHANGES.txt, which was missed in a previous git sync and 3.20.0 release (release notes have been updated). This is a minor breaking change and should be documented. (#9782)