Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add disallowment of setting numpy singleton arrays and multi-dimensio… #9788

Merged
merged 2 commits into from
Apr 14, 2022
Merged

Add disallowment of setting numpy singleton arrays and multi-dimensio… #9788

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dcbdfdb
Add disallowment of setting numpy singleton arrays and multi-dimensio…
zhangskz Apr 14, 2022
0c41981
Explicitly label breaking change and call out fix
zhangskz Apr 14, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGES.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,8 @@
JSON serializations with UTF-8 or other non-ASCII encodings.
* Added experimental support for directly assigning numpy scalars and array.
* Improve the calculation of public_dependencies in DescriptorPool.
* [Breaking Change] Disallow setting fields to numpy singleton arrays or repeated fields to numpy
multi-dimensional arrays. Numpy arrays should be indexed or flattened explicitly before assignment.

Compiler
* Migrate IsDefault(const std::string*) and UnsafeSetDefault(const std::string*)
Expand Down