Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set allow_empty = True on file globs #19

Merged
merged 1 commit into from
Oct 11, 2024

Conversation

acozzette
Copy link
Member

This allows everything to build successfully with the --incompatible_disallow_empty_glob flag, which will eventually be enabled by default. I believe these particular globs are expected to be empty if Ruby is not installed locally.

This allows everything to build successfully with the
`--incompatible_disallow_empty_glob` flag, which will eventually by
enabled by default. I believe these particular globs are expected to be
empty if Ruby is not installed locally.
@JasonLunn JasonLunn merged commit e9db423 into protocolbuffers:main Oct 11, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants