Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bus stops missing in POIs #163

Closed
eikes opened this issue Oct 26, 2023 · 6 comments · Fixed by #164
Closed

Bus stops missing in POIs #163

eikes opened this issue Oct 26, 2023 · 6 comments · Fixed by #164

Comments

@eikes
Copy link
Contributor

eikes commented Oct 26, 2023

The tileset does not include bus stops. It would be nice to have them.
@eikes eikes mentioned this issue Oct 26, 2023
Merged
@bdon
Copy link
Member

bdon commented Oct 29, 2023

Thanks for the PR! @nvkelso it looks like bus_stop is defined in Tilezen for z16, which we don't do for tileset v3. So it makes sense for v3 to add this additively.

In general we should continue with additions that align with Tilezen, this one looks like it should have a minimal impact on overall tile size.

@nvkelso
Copy link
Collaborator

nvkelso commented Oct 30, 2023

Looking at the Tilezen source code (ultimate source of truth versus docs), zoom 18 is more appropriate. Otherwise they really crowd the map!

@bdon bdon closed this as completed in #164 Oct 31, 2023
@bdon
Copy link
Member

bdon commented Oct 31, 2023

Need to add a visualization for bus stops, blocked on #160

@bdon bdon reopened this Oct 31, 2023
bdon added a commit that referenced this issue Nov 5, 2023
@bdon
allow for POIs that have a display minZoom of >15 [#163]
c62fb31
bdon added a commit that referenced this issue Nov 9, 2023
@bdon
bus_stop zoom off by 1 [#163] (#176)
a37d807 
* allow for POIs that have a display minZoom of >15 [#163]

* formatting
bdon added a commit that referenced this issue Nov 11, 2023
@bdon
fix bus stops pmap:kind in POI layer [#163]
48e0281
@bdon bdon mentioned this issue Nov 11, 2023
Merged
bdon added a commit that referenced this issue Nov 11, 2023
@bdon
Bus stops bridges (#180)
5df914b 
* fix bus stops pmap:kind in POI layer [#163]

* Layer reordering for bridges and water [#67]
* move pedestrian landuse over water
* move water strokes to be just over water polygons
@bdon
Copy link
Member

bdon commented Nov 12, 2023

@eikes this is in the latest daily build:

https://protomaps.github.io/PMTiles/?url=https%3A%2F%2Fbuild.protomaps.com%2F20231111.pmtiles#map=18.33/37.765429/-122.419588
Screenshot 2023-11-12 at 11 56 31

@eikes
Copy link
Contributor Author

eikes commented Nov 13, 2023

Nice!

@bdon
Copy link
Member

bdon commented Oct 23, 2024

Bus stop icons are in styles 4.2:
CleanShot 2024-10-23 at 15 08 32@2x

@bdon bdon closed this as completed Oct 23, 2024
alexandresoro pushed a commit to alexandresoro/ouca that referenced this issue Oct 24, 2024
@alexandresoro
fix(deps): update dependency protomaps-themes-base to v4.2.0 (#264)
df0125f 
This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [protomaps-themes-base](https://github.com/protomaps/basemaps) | dependencies | minor | [`4.1.0` -> `4.2.0`](https://renovatebot.com/diffs/npm/protomaps-themes-base/4.1.0/4.2.0) |

---

### Release Notes

<details>
<summary>protomaps/basemaps (protomaps-themes-base)</summary>

### [`v4.2.0`](https://github.com/protomaps/basemaps/blob/HEAD/CHANGELOG.md#Styles-v420)

[Compare Source](protomaps/basemaps@8ec42aa...1de7755)

-   add icons for a few lapis and slategray POIs \[[#&#8203;238](protomaps/basemaps#238), [#&#8203;163](protomaps/basemaps#163)]
-   adjust light theme earth color
-   add fonts and landcover as optional properties of `Theme` interface

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC4xMzAuMSIsInVwZGF0ZWRJblZlciI6IjM4LjEzMC4xIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJkZXBlbmRlbmNpZXMiXX0=-->

Reviewed-on: https://git.tristess.app/alexandresoro/ouca/pulls/264
Reviewed-by: Alexandre Soro <code@soro.dev>
Co-authored-by: renovate <renovate@git.tristess.app>
Co-committed-by: renovate <renovate@git.tristess.app>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Adds bus stops to POIs eikes/basemaps
3 participants
@bdon @eikes @nvkelso