Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixing sonar code smells #1826

Merged
merged 7 commits into from
Apr 27, 2022
Merged

fixing sonar code smells #1826

merged 7 commits into from
Apr 27, 2022

Conversation

rAzizbekyan
Copy link
Contributor

  • Breaking change? (if so, please describe the impact and migration path for existing application instances)

What changes did you make? (Give an overview)

Is there anything you'd like reviewers to focus on?

How Has This Been Tested? (put an "x" (case-sensitive!) next to an item)

  • No need to
  • Manually (please, describe, if necessary)
  • Unit checks
  • Integration checks
  • Covered by existing automation

Checklist (put an "x" (case-sensitive!) next to all the items, otherwise the build will fail)

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (e.g. ENVIRONMENT VARIABLES)
  • My changes generate no new warnings (e.g. Sonar is happy)
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged

Check out Contributing and Code of Conduct

A picture of a cute animal (not mandatory but encouraged)

@rAzizbekyan rAzizbekyan self-assigned this Apr 12, 2022
@rAzizbekyan rAzizbekyan linked an issue Apr 12, 2022 that may be closed by this pull request
Improve SonarCloud metrics #1644
Closed
@github-actions github-actions bot added the status/triage Issues pending maintainers triage label Apr 12, 2022
@rAzizbekyan
Copy link
Contributor Author

WIP

@Haarolean Haarolean marked this pull request as draft April 12, 2022 16:28
workshur
workshur reviewed Apr 12, 2022
View reviewed changes
Copy link
Member

@workshur workshur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good so far

kafka-ui-react-app/src/serviceWorker.ts Outdated Show resolved Hide resolved
@workshur workshur self-requested a review April 12, 2022 17:18
@Haarolean
Copy link
Contributor

@rAzizbekyan please set the correct labels once the PR is ready

@rAzizbekyan rAzizbekyan marked this pull request as ready for review April 15, 2022 09:27
@rAzizbekyan rAzizbekyan requested a review from simonyandev April 15, 2022 10:34
@rAzizbekyan rAzizbekyan removed the status/triage Issues pending maintainers triage label Apr 15, 2022
@Haarolean Haarolean requested a review from a team April 19, 2022 00:30
@rAzizbekyan rAzizbekyan requested a review from a team April 19, 2022 10:06
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

93.1% 93.1% Coverage
0.0% 0.0% Duplication

@rAzizbekyan rAzizbekyan merged commit a55068d into master Apr 27, 2022
@rAzizbekyan rAzizbekyan deleted the issues/1644 branch April 27, 2022 10:17
@Haarolean Haarolean added the type/chore Boring stuff, could be refactoring or tech debt label Apr 27, 2022
rAzizbekyan added a commit that referenced this pull request Apr 27, 2022
@rAzizbekyan @workshur
Implement code highlighting for smart filters (#1868)
0694ff1 
* Implement code highlighting for smart filters

* delete unnecessary code

* fixing eslint problem

* fixing sonar code smells (#1826)

* fixing sonar code smells

* removing unnecessary change

* fixing some sonar code smell issues

* making requested changes

* Fix sonar badges in readme (#1906)

* fixing merge conflicts

Co-authored-by: Oleg Shur <workshur@gmail.com>
simonyandev added a commit that referenced this pull request May 2, 2022
@simonyandev @rAzizbekyan @workshur
Refetch topics list to display the updated data (#1900)
7c21e50 
* refetch topics list to display the updated data

* fixing sonar code smells (#1826)

* fixing sonar code smells

* removing unnecessary change

* fixing some sonar code smell issues

* making requested changes

* Fix sonar badges in readme (#1906)

Co-authored-by: Robert Azizbekyan <103438454+rAzizbekyan@users.noreply.github.com>
Co-authored-by: Oleg Shur <workshur@gmail.com>
simonyandev pushed a commit that referenced this pull request May 4, 2022
@rAzizbekyan @workshur @simonyandev
Implement code highlighting for smart filters (#1868)
3275b3f 
* Implement code highlighting for smart filters

* delete unnecessary code

* fixing eslint problem

* fixing sonar code smells (#1826)

* fixing sonar code smells

* removing unnecessary change

* fixing some sonar code smell issues

* making requested changes

* Fix sonar badges in readme (#1906)

* fixing merge conflicts

Co-authored-by: Oleg Shur <workshur@gmail.com>
simonyandev added a commit that referenced this pull request May 4, 2022
@simonyandev @rAzizbekyan @workshur
Refetch topics list to display the updated data (#1900)
2b5917d 
* refetch topics list to display the updated data

* fixing sonar code smells (#1826)

* fixing sonar code smells

* removing unnecessary change

* fixing some sonar code smell issues

* making requested changes

* Fix sonar badges in readme (#1906)

Co-authored-by: Robert Azizbekyan <103438454+rAzizbekyan@users.noreply.github.com>
Co-authored-by: Oleg Shur <workshur@gmail.com>
rAzizbekyan added a commit that referenced this pull request May 12, 2022
@rAzizbekyan @simonyandev @workshur
Refactor TopicMessages's store to redux/toolkit (#1902)
81d1e95 
* Refactor TopicMessages's store to redux/toolkit

* adding test cases to improve coverage

* fixing eslint error

* removing extra code

* Transform redux connect reducer and actions into toolkit slice. (#1883)

* integrate redux toolkit for connects

* uncomment test case

* remove unnecessary comment

* reduce duplication

* Implement code highlighting for smart filters (#1868)

* Implement code highlighting for smart filters

* delete unnecessary code

* fixing eslint problem

* fixing sonar code smells (#1826)

* fixing sonar code smells

* removing unnecessary change

* fixing some sonar code smell issues

* making requested changes

* Fix sonar badges in readme (#1906)

* fixing merge conflicts

Co-authored-by: Oleg Shur <workshur@gmail.com>

* Add positive notifications after some successful actions. (#1830)

* add some positive notifications after successful actions

* some improvements

* improve alerts reducer tests

* Fix test warnings (#1908)

* fix fetch mock warnings in brokers.spec.tsx

* use separate waitFor-s for fetch-mock call expects

* Persist show internal topics switch state (#1832)

* persist show internal topics switch state

* minor improvements in topics list tests

* prevent duplication in topic list test file

* fix seek type select border-radius and user-select (#1904)

* Refetch topics list to display the updated data (#1900)

* refetch topics list to display the updated data

* fixing sonar code smells (#1826)

* fixing sonar code smells

* removing unnecessary change

* fixing some sonar code smell issues

* making requested changes

* Fix sonar badges in readme (#1906)

Co-authored-by: Robert Azizbekyan <103438454+rAzizbekyan@users.noreply.github.com>
Co-authored-by: Oleg Shur <workshur@gmail.com>

* Show confirmation modal when clear messages is clicked in topics list (#1899)

* show confirmation modal when clear messages is clicked in topics list

* change variable name

* add missing dependencies

* use useModal hook for topics list modals

* display a human-readable error message for topic custom parameers value field (#1896)

* modify dependencies to fix partitions filter bug (#1901)

Co-authored-by: Arsen Simonyan <103444767+simonyandev@users.noreply.github.com>
Co-authored-by: Oleg Shur <workshur@gmail.com>
javalover123 pushed a commit to javalover123/kafka-ui that referenced this pull request Dec 7, 2022
@rAzizbekyan
fixing sonar code smells (provectus#1826)
3b18709 
* fixing sonar code smells

* removing unnecessary change

* fixing some sonar code smell issues

* making requested changes
javalover123 pushed a commit to javalover123/kafka-ui that referenced this pull request Dec 7, 2022
@rAzizbekyan @workshur @simonyandev
Implement code highlighting for smart filters (provectus#1868)
5d968e4 
* Implement code highlighting for smart filters

* delete unnecessary code

* fixing eslint problem

* fixing sonar code smells (provectus#1826)

* fixing sonar code smells

* removing unnecessary change

* fixing some sonar code smell issues

* making requested changes

* Fix sonar badges in readme (provectus#1906)

* fixing merge conflicts

Co-authored-by: Oleg Shur <workshur@gmail.com>
javalover123 pushed a commit to javalover123/kafka-ui that referenced this pull request Dec 7, 2022
@simonyandev @rAzizbekyan @workshur
Refetch topics list to display the updated data (provectus#1900)
dfc5d86 
* refetch topics list to display the updated data

* fixing sonar code smells (provectus#1826)

* fixing sonar code smells

* removing unnecessary change

* fixing some sonar code smell issues

* making requested changes

* Fix sonar badges in readme (provectus#1906)

Co-authored-by: Robert Azizbekyan <103438454+rAzizbekyan@users.noreply.github.com>
Co-authored-by: Oleg Shur <workshur@gmail.com>
javalover123 pushed a commit to javalover123/kafka-ui that referenced this pull request Dec 7, 2022
@rAzizbekyan @simonyandev @workshur
Refactor TopicMessages's store to redux/toolkit (provectus#1902)
cf730ca 
* Refactor TopicMessages's store to redux/toolkit

* adding test cases to improve coverage

* fixing eslint error

* removing extra code

* Transform redux connect reducer and actions into toolkit slice. (provectus#1883)

* integrate redux toolkit for connects

* uncomment test case

* remove unnecessary comment

* reduce duplication

* Implement code highlighting for smart filters (provectus#1868)

* Implement code highlighting for smart filters

* delete unnecessary code

* fixing eslint problem

* fixing sonar code smells (provectus#1826)

* fixing sonar code smells

* removing unnecessary change

* fixing some sonar code smell issues

* making requested changes

* Fix sonar badges in readme (provectus#1906)

* fixing merge conflicts

Co-authored-by: Oleg Shur <workshur@gmail.com>

* Add positive notifications after some successful actions. (provectus#1830)

* add some positive notifications after successful actions

* some improvements

* improve alerts reducer tests

* Fix test warnings (provectus#1908)

* fix fetch mock warnings in brokers.spec.tsx

* use separate waitFor-s for fetch-mock call expects

* Persist show internal topics switch state (provectus#1832)

* persist show internal topics switch state

* minor improvements in topics list tests

* prevent duplication in topic list test file

* fix seek type select border-radius and user-select (provectus#1904)

* Refetch topics list to display the updated data (provectus#1900)

* refetch topics list to display the updated data

* fixing sonar code smells (provectus#1826)

* fixing sonar code smells

* removing unnecessary change

* fixing some sonar code smell issues

* making requested changes

* Fix sonar badges in readme (provectus#1906)

Co-authored-by: Robert Azizbekyan <103438454+rAzizbekyan@users.noreply.github.com>
Co-authored-by: Oleg Shur <workshur@gmail.com>

* Show confirmation modal when clear messages is clicked in topics list (provectus#1899)

* show confirmation modal when clear messages is clicked in topics list

* change variable name

* add missing dependencies

* use useModal hook for topics list modals

* display a human-readable error message for topic custom parameers value field (provectus#1896)

* modify dependencies to fix partitions filter bug (provectus#1901)

Co-authored-by: Arsen Simonyan <103444767+simonyandev@users.noreply.github.com>
Co-authored-by: Oleg Shur <workshur@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simonyandev simonyandev simonyandev approved these changes

@lazzy-panda lazzy-panda lazzy-panda approved these changes

@workshur workshur workshur approved these changes

@Mgrdich Mgrdich Awaiting requested review from Mgrdich

@Haarolean Haarolean Awaiting requested review from Haarolean

Assignees

@rAzizbekyan rAzizbekyan

Labels
scope/frontend type/chore Boring stuff, could be refactoring or tech debt
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve SonarCloud metrics
6 participants
@rAzizbekyan @Haarolean @workshur @lazzy-panda @Mgrdich @simonyandev