Refactor TopicMessages's store to redux/toolkit #1902
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rAzizbekyan
requested review from
workshur,
Haarolean,
lazzy-panda,
Mgrdich and
simonyandev
workshur
approved these changes
Apr 26, 2022
|
@rAzizbekyan looks good so far. Please ask @Haarolean to test messages UI before merge |
simonyandev
suggested changes
Apr 26, 2022
There was a problem hiding this comment.
I can see a lot of thunk actions are left and only two of them are transformed into createAsyncThunk. All those thunks need to become createAsyncThunk and all those action types like 'GET_TOPIC_CONSUMER_GROUPS__FAILURE' must be removed, the toolkit will handle them. Also, make sure they are not left in other places too like where loaders and alerts are handled.
simonyandev
approved these changes
Apr 26, 2022
Mgrdich
approved these changes
Apr 26, 2022
ok we'll schedule a QA round for this |
* integrate redux toolkit for connects * uncomment test case * remove unnecessary comment * reduce duplication
* Implement code highlighting for smart filters * delete unnecessary code * fixing eslint problem * fixing sonar code smells (#1826) * fixing sonar code smells * removing unnecessary change * fixing some sonar code smell issues * making requested changes * Fix sonar badges in readme (#1906) * fixing merge conflicts Co-authored-by: Oleg Shur <workshur@gmail.com>
* add some positive notifications after successful actions * some improvements * improve alerts reducer tests
* fix fetch mock warnings in brokers.spec.tsx * use separate waitFor-s for fetch-mock call expects
* persist show internal topics switch state * minor improvements in topics list tests * prevent duplication in topic list test file
* refetch topics list to display the updated data * fixing sonar code smells (#1826) * fixing sonar code smells * removing unnecessary change * fixing some sonar code smell issues * making requested changes * Fix sonar badges in readme (#1906) Co-authored-by: Robert Azizbekyan <103438454+rAzizbekyan@users.noreply.github.com> Co-authored-by: Oleg Shur <workshur@gmail.com>
…#1899) * show confirmation modal when clear messages is clicked in topics list * change variable name * add missing dependencies * use useModal hook for topics list modals
Mgrdich
reviewed
May 4, 2022
kafka-ui-react-app/src/redux/reducers/topicMessages/topicMessagesSlice.ts
Show resolved
Hide resolved
lazzy-panda
approved these changes
May 5, 2022
|
SonarCloud Quality Gate failed. |
javalover123
pushed a commit
to javalover123/kafka-ui
that referenced
this pull request
Dec 7, 2022
* Refactor TopicMessages's store to redux/toolkit * adding test cases to improve coverage * fixing eslint error * removing extra code * Transform redux connect reducer and actions into toolkit slice. (provectus#1883) * integrate redux toolkit for connects * uncomment test case * remove unnecessary comment * reduce duplication * Implement code highlighting for smart filters (provectus#1868) * Implement code highlighting for smart filters * delete unnecessary code * fixing eslint problem * fixing sonar code smells (provectus#1826) * fixing sonar code smells * removing unnecessary change * fixing some sonar code smell issues * making requested changes * Fix sonar badges in readme (provectus#1906) * fixing merge conflicts Co-authored-by: Oleg Shur <workshur@gmail.com> * Add positive notifications after some successful actions. (provectus#1830) * add some positive notifications after successful actions * some improvements * improve alerts reducer tests * Fix test warnings (provectus#1908) * fix fetch mock warnings in brokers.spec.tsx * use separate waitFor-s for fetch-mock call expects * Persist show internal topics switch state (provectus#1832) * persist show internal topics switch state * minor improvements in topics list tests * prevent duplication in topic list test file * fix seek type select border-radius and user-select (provectus#1904) * Refetch topics list to display the updated data (provectus#1900) * refetch topics list to display the updated data * fixing sonar code smells (provectus#1826) * fixing sonar code smells * removing unnecessary change * fixing some sonar code smell issues * making requested changes * Fix sonar badges in readme (provectus#1906) Co-authored-by: Robert Azizbekyan <103438454+rAzizbekyan@users.noreply.github.com> Co-authored-by: Oleg Shur <workshur@gmail.com> * Show confirmation modal when clear messages is clicked in topics list (provectus#1899) * show confirmation modal when clear messages is clicked in topics list * change variable name * add missing dependencies * use useModal hook for topics list modals * display a human-readable error message for topic custom parameers value field (provectus#1896) * modify dependencies to fix partitions filter bug (provectus#1901) Co-authored-by: Arsen Simonyan <103444767+simonyandev@users.noreply.github.com> Co-authored-by: Oleg Shur <workshur@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes did you make? (Give an overview)
Is there anything you'd like reviewers to focus on?
How Has This Been Tested? (put an "x" (case-sensitive!) next to an item)
Checklist (put an "x" (case-sensitive!) next to all the items, otherwise the build will fail)
Check out Contributing and Code of Conduct
A picture of a cute animal (not mandatory but encouraged)